jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

Migrate appSettings and userSettings to TypeScript

Open terite opened this issue 1 year ago • 8 comments

In an attempt to keep code changes minimal, I added some FIXME comments to relevant places instead of changing behavior.

Changes

  • Migrate AppSettings to TypeScript
  • Migrate UserSettings to TypeScript
  • Remove the UserSettings.getData method
  • Remove the UserSettings.importFrom method

Issues

terite avatar Dec 31 '23 09:12 terite

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Dec 31 '23 09:12 sonarqubecloud[bot]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

jellyfin-bot avatar Jan 12 '24 21:01 jellyfin-bot

I'm not sure what's up with eslint. Locally my npm run lint has no errors (but 39 warnings, mostly not these files). I'll wait for feedback before continuing further there.

terite avatar Feb 12 '24 09:02 terite

Quality Gate Passed Quality Gate passed

Issues
14 New issues

Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 18 '24 00:02 sonarqubecloud[bot]

Cloudflare Pages deployment

Latest commit 8e71295
Status ✅ Deployed!
Preview URL https://c9fdf9f3.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs View bot logs

jellyfin-bot avatar Feb 18 '24 00:02 jellyfin-bot

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

jellyfin-bot avatar Mar 22 '24 23:03 jellyfin-bot

Hey @terite! Now that 10.9 is finally out the door, could you update this branch and we'll get it merged? Thanks!

thornbill avatar May 18 '24 05:05 thornbill