jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

Replace "Object.assign()" With an Object Spread

Open Adam4376 opened this issue 1 year ago • 5 comments

This is a change requested by this issue on Sonar Cloud

Adam4376 avatar Nov 28 '23 00:11 Adam4376

Typically what I look for in these type of cleanup PRs is that they fix all instances of the issue and add an eslint rule (if possible) to prevent new instances from being added.

Thanks!

thornbill avatar Nov 29 '23 18:11 thornbill

Typically what I look for in these type of cleanup PRs is that they fix all instances of the issue and add an eslint rule (if possible) to prevent new instances from being added.

* [all reported violations of this rule](https://sonarcloud.io/project/issues?resolved=false&rules=javascript%3AS6661&id=jellyfin_jellyfin-web)

* [eslint rule](https://eslint.org/docs/latest/rules/prefer-object-spread)

Thanks!

I believe I've changed all the usages. Added the eslint rule as well.

Adam4376 avatar Dec 18 '23 19:12 Adam4376

Cloudflare Pages deployment

Latest commit 9694462
Status ✅ Deployed!
Preview URL https://156cc6aa.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs View bot logs

jellyfin-bot avatar Jan 05 '24 21:01 jellyfin-bot

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 12 '24 18:01 sonarqubecloud[bot]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

jellyfin-bot avatar Jan 17 '24 17:01 jellyfin-bot