jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

Published 20 hours ago • verified publisher icon jellyfin

No admin user can be allowed to "edit subtitles"

Open Ch1nkara opened this issue 1 year ago • 8 comments

Add new feature: ability for a user to "Edit subtitles" without administrator rights

Changes Edit itemContextMenu.js to allow "edit subtitle" if user have PermissionKind EnableSubtitleManagement Edit profile.tsx to have a checkbox to allow/forbid PermissionKind EnableSubtitleManagement

Related PR:

~~TODO~~

  • ~~Fix https://github.com/jellyfin/jellyfin-plugin-opensubtitles/issues/131#issuecomment-1677299539 in opensubtitle plugin~~ Done:
  1. https://github.com/jellyfin/jellyfin-plugin-opensubtitles/pull/138
  2. https://github.com/jellyfin/jellyfin/pull/10499

Issues https://features.jellyfin.org/posts/185/non-admin-users-download-subtitles

Ch1nkara avatar Oct 15 '23 20:10 Ch1nkara

The PR was accepted and merged on the backend (ref: https://github.com/jellyfin/jellyfin/pull/10410). Is there something else missing for this one ?

Ch1nkara avatar Oct 30 '23 23:10 Ch1nkara

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 08 '23 16:11 sonarqubecloud[bot]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

jellyfin-bot avatar Jan 14 '24 02:01 jellyfin-bot

@Ch1nkara could you have another look at the requested changes and merge conflicts? This would be a really useful feature :)

Simsala91 avatar Feb 05 '24 12:02 Simsala91

Changes made. @thornbill Does this meet the requirements ?

Ch1nkara avatar Feb 06 '24 09:02 Ch1nkara

You'll need to fix the merge conflicts by rebasing or merging the master branch.

nielsvanvelzen avatar Feb 06 '24 09:02 nielsvanvelzen

@Ch1nkara Could you take another look at this? Would be very appreciated ❤️

Simsala91 avatar Mar 06 '24 12:03 Simsala91

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 07 '24 09:03 sonarqubecloud[bot]

Cloudflare Pages deployment

Latest commit 5c60f99
Status ✅ Deployed!
Preview URL https://4d8caae4.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs View bot logs

jellyfin-bot avatar Mar 07 '24 13:03 jellyfin-bot

I've tested this a bit, and as far as I can see, this permission only allows adding new subtitles, not deleting existing ones. This can be really confusing, since you might add a subtitle (maybe download it direclty with the OpenSubtitle Plugin), check if it is fitting for the content, and if it is not, you can't delete it again and have to contact the system admin to delete the wrong version again. Also, manually adding subtitle file does not work (but doesn't for admin either). Only adding subtitles with OpenSubtitlesPlugin works.

Tested version: 10.9, build 2024040805

https://github.com/jellyfin/jellyfin/issues/11318

Simsala91 avatar Apr 08 '24 14:04 Simsala91