jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

Add "AllowedTags" option to parental controls

Open Jpuc1143 opened this issue 1 year ago • 14 comments

Changes Adds an option in Parental Controls to only allow media with selected tags for viewing.

Issues Client side configuration of jellyfin/jellyfin#9139

Jpuc1143 avatar Feb 08 '23 23:02 Jpuc1143

Hey @Jpuc1143 since the backend changes for this have been merged now, could you resolve the merge conflict here? Thanks!

thornbill avatar Mar 10 '23 16:03 thornbill

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Mar 14 '23 16:03 sonarcloud[bot]

Is the backend implemented as expected @Jpuc1143 ?

It seems unintuitive to require setting the tag on the library itself, and even then, the /Items request fails to list the tagged items. I am forced to provide the direct link to the item. Is there an additional metadata item which must be tagged for listing a library?

Edit: Seasons for a show similarly do not display even if each episode is tagged

xangelix avatar Mar 25 '23 19:03 xangelix

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

jellyfin-bot avatar Mar 29 '23 21:03 jellyfin-bot

Any progress on this?

nalroni avatar Jul 18 '23 13:07 nalroni

@Jpuc1143 would be nice if you can rebase on master

Shadowghost avatar Aug 14 '23 09:08 Shadowghost

+1 as soon as this is added I can finally get migrated over from plex :)

harri-clarke avatar Sep 20 '23 17:09 harri-clarke

+1 also from me. Urgently needed.

cutzenfriend avatar Dec 31 '23 10:12 cutzenfriend

Easily the most needed feature in jellyfin

On Sun, Dec 31, 2023, 5:48 AM cutzenfriend @.***> wrote:

+1 also from me. Urgently needed.

— Reply to this email directly, view it on GitHub https://github.com/jellyfin/jellyfin-web/pull/4338#issuecomment-1872918455, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFY2HH4FHP5KYM3UXY3TQLYME7JVAVCNFSM6AAAAAAUV3AVGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSHEYTQNBVGU . You are receiving this because you commented.Message ID: @.***>

nalroni avatar Dec 31 '23 17:12 nalroni

Any timeframe when this will be released?

brutelxr avatar Feb 03 '24 23:02 brutelxr

No. Additionally this change has not even been merged to master/unstable. This PR seems to have been abandoned by the original author and there are reports that the updated PR opened by someone else is not working as expected... so it still needs reviewed and additional testing.

thornbill avatar Feb 07 '24 13:02 thornbill

I wonder if the main dev team would consider picking this option up? It's a critical tool for parental controls

On Wed, Feb 7, 2024, 8:23 AM Bill Thornton @.***> wrote:

No https://jellyfin.org/docs/general/faq#when-will-release-x-happen-when-will-feature-x-be-available. Additionally this change has not even been merged to master/unstable. This PR seems to have been abandoned by the original author and there are reports that the updated PR opened by someone else is not working as expected... so it still needs reviewed and additional testing.

— Reply to this email directly, view it on GitHub https://github.com/jellyfin/jellyfin-web/pull/4338#issuecomment-1932043453, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFY2HFDMX2IZYLIB3F4WK3YSN56ZAVCNFSM6AAAAAAUV3AVGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGA2DGNBVGM . You are receiving this because you commented.Message ID: @.***>

nalroni avatar Feb 07 '24 13:02 nalroni

I wonder if the main dev team would consider picking this option up?

Yes, I plan to make necessary changes to anything that I have tagged with the 10.9.0 milestone if the PR author does not address feedback or conflicts (which is the case for the updated PR). If the feature is not functioning as expected, that may require additional changes server side though.

thornbill avatar Feb 07 '24 15:02 thornbill

That's awesome! Thank you for the response and support.

On Wed, Feb 7, 2024, 10:45 AM Bill Thornton @.***> wrote:

I wonder if the main dev team would consider picking this option up?

Yes, I plan to make necessary changes to anything that I have tagged with the 10.9.0 milestone if the PR author does not address feedback or conflicts (which is the case for the updated PR). If the feature is not functioning as expected, that may require additional changes server side though.

— Reply to this email directly, view it on GitHub https://github.com/jellyfin/jellyfin-web/pull/4338#issuecomment-1932324775, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFY2HG37ALXE4KODU6R643YSOOP3AVCNFSM6AAAAAAUV3AVGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGMZDINZXGU . You are receiving this because you commented.Message ID: @.***>

nalroni avatar Feb 07 '24 15:02 nalroni

Superseded by #4535

thornbill avatar Mar 25 '24 07:03 thornbill