jellyfin-web
jellyfin-web copied to clipboard
Allow Safari versions above 13 to play HVEC
Changes Currently, the client is hardcoded not to allow HVEC playback on Safari even though it supports it, because "some version was lying about support". Since modern versions of Safari do support HVEC, I've added a condition to check if the Safari version is greater than or equal to Version 13, since prior versions required macOS 10.13 High Sierra to support HVEC, and so I assume that is where Safari "lying" about support became a problem. Ideally, I think the hardcoding should be removed altogether, but this is a gentler solution.
Issues
- #4216
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
I think something went wrong with your merge/rebase...
These merge commits were added into this branch cleanly.
It's always possible, I couldn't get the dev environment to work to test that it was successful.
But I definitely did have to resolve a conflict or two in order to merge.
The PR shows that it doesn't contain any changes now, so something must have went wrong. :upside_down_face:
All fixed :)
I just had a very similar issue where most of my library which is transcoded to AAC wouldnt play on safari. Enabling HEVC was the fix. I wonder why this was never merged???
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
@Southpaw1496 This is superseded by #5183
👍 I'll close