jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

Allow Safari versions above 13 to play HVEC

Open Southpaw1496 opened this issue 1 year ago • 9 comments

Changes Currently, the client is hardcoded not to allow HVEC playback on Safari even though it supports it, because "some version was lying about support". Since modern versions of Safari do support HVEC, I've added a condition to check if the Safari version is greater than or equal to Version 13, since prior versions required macOS 10.13 High Sierra to support HVEC, and so I assume that is where Safari "lying" about support became a problem. Ideally, I think the hardcoding should be removed altogether, but this is a gentler solution.

Issues

  • #4216

Southpaw1496 avatar Jan 30 '23 08:01 Southpaw1496

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Jan 30 '23 09:01 sonarcloud[bot]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

jellyfin-bot avatar Apr 19 '23 12:04 jellyfin-bot

I think something went wrong with your merge/rebase...

These merge commits were added into this branch cleanly.

thornbill avatar May 03 '23 13:05 thornbill

It's always possible, I couldn't get the dev environment to work to test that it was successful.

Southpaw1496 avatar May 03 '23 13:05 Southpaw1496

But I definitely did have to resolve a conflict or two in order to merge.

Southpaw1496 avatar May 03 '23 13:05 Southpaw1496

The PR shows that it doesn't contain any changes now, so something must have went wrong. :upside_down_face:

thornbill avatar May 03 '23 14:05 thornbill

All fixed :)

Southpaw1496 avatar May 03 '23 15:05 Southpaw1496

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar May 03 '23 15:05 sonarcloud[bot]

I just had a very similar issue where most of my library which is transcoded to AAC wouldnt play on safari. Enabling HEVC was the fix. I wonder why this was never merged???

bleak183 avatar Feb 28 '24 18:02 bleak183

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

jellyfin-bot avatar Mar 08 '24 02:03 jellyfin-bot

@Southpaw1496 This is superseded by #5183

nyanmisaka avatar Mar 08 '24 03:03 nyanmisaka

👍 I'll close

thornbill avatar Mar 08 '24 03:03 thornbill