jellyfin-web
jellyfin-web copied to clipboard
jellyfin
If there are quite a few artists in one album they overflow the UI.
Describe The Bug When an album i have in my music library has quite a few artists (about 15) they overflow off the UI bar where the album buttons are. (Heart, Shuffle, Mix, Play)
Expected Behavior
I don't expect anything really, besides for it to not overflow lol.
maybe if there are over 10 artists: say something along the lines of "and {} others..." after it says the first 10?
A quick and dirty inspect element job kinda shows what i mean:
Screenshots
System (please complete the following information):
- Platform: Linux, ChromeOS
- Browser: Chrome, Firefox
- Jellyfin Version: 10.8.7
I came over from the Jellyfin sub Reddit, after learning that the best way to help is through OSS contributions. I've been a React dev for the past 4 years and would like to take this issue on
Feel free to work on this issue. As you might have found out already; not all parts of the web client are rewritten in React. I'm not sure about this specific page (I don't really work on the web client). If you have any questions our developers are most active on Matrix/Discord.
Hi, just wanted to ask out of curiosity if this issue has been resolved or worked on yet. thanks.
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.
bump. this still affects me on the latest docker version of jellyfin web.
I would like to fix this issue. I will be working on it and when I finish I will submit my PR.
Could someone verify the fix in #4830 is working as expected by testing the Preview URL: https://github.com/jellyfin/jellyfin-web/pull/4830#issuecomment-1777917418
I can't seem to find an album that has enough artists to trigger this bug in my library. :sweat_smile:
Image from @Xitee1 (https://github.com/jellyfin/jellyfin/issues/10052#issuecomment-1868077418) to show extreme cases
As I already mentioned in jellyfin/jellyfin#10052, I don't think that concatinating the artists is a good idea. The problem with these kinds of albums (at least in my opinion) is that they normally are some kind of compilation with no defined album artist. The way e.g. spotify solves this issue is to show "Various artists" (unclickable) as the album artist.
Concatinating the available artists may fix the overflow, but regarding UX you still have another problem: Jellyfin web doesn't show the artist of the individual tracks if it "matches" with the album artist. Let's say you have an album with multiple remixes or
bump. this still affects me on the latest docker version of jellyfin web.
You don't get to know the artist corresponding to the track and the artists in the header are always sorted alphabetically which also doesn't help in this case.
What i proposed in the mentioned issue (jellyfin/jellyfin#10052) was:
What should Jellyfin do?
(My suggestions)
- Maybe tag these albums (no album artist, multiple artists) as compilations or something like that? Perhaps clients can handle this specific case more easily with this information
- Show "Various Artists" (best case: translated) as album artist without generating an artist page. Clients should not make this text clickable. Maybe an option would be to leave the album artist field empty (I don't know what the current behavior is) and let the clients handle this case. Hot take: every piece of music/media was created by at least one person. So if no person is credited for the whole unit/album showing "Various Artists" would always be correct because multiple artists worked on it? (I think this would be the best and easiest option)
- Jellyfin-web: Show the individual artist per Track
That were just the ideas I came up with but I think that shortening the list isn't a good solution to this problem
I tried investigating further and noticed some interesting behavior: https://github.com/jellyfin/jellyfin/issues/10052#issuecomment-1925000577
TLDR: An empty album artist leads to a bad import which messes with the UI. The UI also doesn't know how to handle an empty album artist