jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

Convert Movies to react

Open grafixeyehero opened this issue 2 years ago • 1 comments

continued form Convert Home to react https://github.com/jellyfin/jellyfin-web/pull/3567

grafixeyehero avatar Aug 05 '22 22:08 grafixeyehero

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.3% 11.3% Duplication

sonarqubecloud[bot] avatar Sep 03 '22 00:09 sonarqubecloud[bot]

@thornbill which one you prefer for genres view?.

current genres

new genres-2

grafixeyehero avatar Oct 28 '22 16:10 grafixeyehero

I prefer the current UI

thornbill avatar Oct 28 '22 16:10 thornbill

Looks like the one action failed due to a type error:

ERROR in /home/runner/work/jellyfin-web/jellyfin-web/src/routes/movies/GenresView.tsx
./routes/movies/GenresView.tsx 24:21-33
[tsl] ERROR in /home/runner/work/jellyfin-web/jellyfin-web/src/routes/movies/GenresView.tsx(24,22)
      TS2345: Argument of type 'BaseItemDto[] | null | undefined' is not assignable to parameter of type 'SetStateAction<BaseItemDto[]>'.
  Type 'undefined' is not assignable to type 'SetStateAction<BaseItemDto[]>'.

thornbill avatar Oct 28 '22 21:10 thornbill

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

sonarqubecloud[bot] avatar Nov 01 '22 15:11 sonarqubecloud[bot]

This causes the movies page to reload every time you click back. So if you're scrolling down on your movies and click one then click back you will lose your place scrolling because it reloads the entire page

brutric avatar Nov 08 '22 22:11 brutric

@thornbill which one you prefer for genres view?.

current genres

new genres-2

i highly prefer genres that you can click. the new one you posted there makes sense. the way it currently is makes no sense whatsoever from a ux standpoint

brutric avatar Nov 08 '22 22:11 brutric

@thornbill which one you prefer for genres view?.

current genres

new genres-2

sc

brutric avatar Nov 08 '22 23:11 brutric

You can click the headings of the genres.

thornbill avatar Nov 13 '22 23:11 thornbill