jellyfin-web
jellyfin-web copied to clipboard
Convert Movies to react
continued form Convert Home to react https://github.com/jellyfin/jellyfin-web/pull/3567
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
11.3% Duplication
@thornbill which one you prefer for genres view?.
current
new
I prefer the current UI
Looks like the one action failed due to a type error:
ERROR in /home/runner/work/jellyfin-web/jellyfin-web/src/routes/movies/GenresView.tsx
./routes/movies/GenresView.tsx 24:21-33
[tsl] ERROR in /home/runner/work/jellyfin-web/jellyfin-web/src/routes/movies/GenresView.tsx(24,22)
TS2345: Argument of type 'BaseItemDto[] | null | undefined' is not assignable to parameter of type 'SetStateAction<BaseItemDto[]>'.
Type 'undefined' is not assignable to type 'SetStateAction<BaseItemDto[]>'.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells
No Coverage information
1.6% Duplication
This causes the movies page to reload every time you click back. So if you're scrolling down on your movies and click one then click back you will lose your place scrolling because it reloads the entire page
@thornbill which one you prefer for genres view?.
current
new
i highly prefer genres that you can click. the new one you posted there makes sense. the way it currently is makes no sense whatsoever from a ux standpoint
@thornbill which one you prefer for genres view?.
current
new

You can click the headings of the genres.