jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

Chapter Image settings(front-end)

Open negulici-r-barnabas opened this issue 2 years ago • 1 comments

Chapter Image (Dummy Chapters) can be configured from the front-end by the user. There are 3 settings:

  • duration (seconds)
  • count
  • resolution (16:9 aspect ratio)

The extraction duration (interval) now can be set in seconds. The minimal value being 1 second. The default value is "300" (5 minutes). The count is the image file limit / media file, just in case there is bad metadata. Default value is "100". The resolution sets the extracted image size. It ranges from 240p to 2160p (16:9 aspect ratio). Default value: "Match Source".

Screenshot of the Dashboard > General settings page: Screenshot 2022-07-18 175753

Screenshot of the resolution dropdown:

Screenshot 2022-07-18 175845

I tried to keep the changes to minimal. I just used the server configuration that was already implemented by adding 3 more properties to its model class.

I'm a beginner coder. I welcome any improvement suggestions.

The issues that would resolve is #1346 (already closed but not implemented). The feature request is here.

This is the front-end implementation. The back-end implementation is here.

negulici-r-barnabas avatar Jul 18 '22 15:07 negulici-r-barnabas

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 22 '22 04:08 sonarqubecloud[bot]

Status on this?

Hypnotist1148 avatar Oct 03 '22 19:10 Hypnotist1148

Web changes are blocked until the server changes are reviewed + merged.

thornbill avatar Oct 03 '22 19:10 thornbill

Hello, sorry for my absence I have modified my code with the requested changes on the back-end and I also added 144p to the list of selectable resolutions.

negulici-r-barnabas avatar Nov 13 '22 14:11 negulici-r-barnabas

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Nov 27 '22 15:11 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Dec 17 '22 11:12 sonarqubecloud[bot]

Is fixing the linting the only thing pending? I'd be happy to address that if that's all it is waiting on.

koosc avatar Feb 05 '23 05:02 koosc

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Feb 07 '23 22:02 sonarqubecloud[bot]