jellyfin-web icon indicating copy to clipboard operation
jellyfin-web copied to clipboard

Several block buttons in the UI don't have a span child

Open Nicryc opened this issue 2 years ago • 0 comments

Describe The Bug

Several block buttons in the Jellyfin web UI are missing a span child and their text is written directly inside the button. This is especially true for formDialogFooterItem buttons but not only.

They look like this:

<button is="emby-button" type="submit" class="raised btnSubmit block formDialogFooterItem button-submit emby-button">
    OK
</button>

The problem is other buttons follow this scheme:

<button is="emby-button" type="button" class="raised button-cancel block btnCancel formDialogFooterItem emby-button">
       <span>Cancel</span> 
</button>

It creates inconsistencies and can cause issues and problems with custom CSS theming.

Steps To Reproduce

Those are places where buttons are affected:

  • Reload metadata ("Reload")
  • Delete media ("Cancel" and "Delete")
  • Add to the playlist ("Add")
  • Add to the collection ("OK")
  • New collection ("OK")
  • Playing error ("Understood")
  • Delete the user ("Cancel" and "Delete")
  • DLNA → Profile ("New")

Sorry if translations are not exact. There could be others, that's just the one I found.

Expected Behavior

All block buttons should contain their text in a span.

System (please complete the following information):

  • Platform: Windows 10
  • Browser: Firefox 102
  • Jellyfin Version: 10.8.1

Nicryc avatar Jul 09 '22 17:07 Nicryc