jellyfin-web
jellyfin-web copied to clipboard
Fix unexpected remuxing of direct playable media
Changes Force bitrate auto detection if transcoding is not allowed for the user.
Issues If the user has set a maximum bitrate and transcoding is blocked after that, direct playable video is never (if its bitrate exeeds the specified one) played direct because of this limit. Moreover, the user can't change the bitrate because the UI is hidden.
Steps To Reproduce
- With allowed transcoding, set the maximum bitrate in
Settings/Playbackto have the direct playable video transcoded. - Block transcoding.
- Refresh page / relogin.
- Start video.
- Remuxing is used instead of DirectPlay. (No DirectPlay because bitrate is exceeded) And there is no way to change this.
I tested passing null bitrate to playAfterBitrateDetect and it seems to work as expected - DirectPlay.
But now I'm leaning towards the idea of ignoring MaxBitrate on the server: if the user doesn't have permission to transcode, the server cannot make the bitrate lower.
There is another option: if the bitrate of the media exceeds the maximum network bitrate (detection required), the media is treated as unsupported.
Server-side alternative: https://github.com/jellyfin/jellyfin/pull/9082
I'd prefer doing this for all clients server side. Nonetheless the drop-down menus should be hidden in web if the user doesn't have transcoding permissions.







