jellyfin-vue
jellyfin-vue copied to clipboard
related items are updated too frequently
The related items are reloaded every single time their base item changes, which also includes some unwanted updates. I propose the watch property is removed to solve it for now.
- favoriting an album
- skipping around while playing several songs in an album
Implementing it in the store like proposed in #980 should fix this problem. Other solutions are workarounds that should not be merged imo.
I'm afk so perhaps some of the context is wrong, but I think it should be done as follows:
• The watcher must be replaced from "item" to "item.Id", so we only get real item changes (where it makes sense to display the skeletons) and not all the changes of the item. You can do this like we do in BlurhashImage for the window breakpoints.
• The request made in refreshItems should only be used to get the itemIds of the similar items. Then, we check if those exists in the item store (if not, add them) and use them, so they're fully reactive.
Making the full-blown getItems
query should also solve the issue I was having in #769 where images of the people didn't appear. I found the reason of it is that this request doesn't include the imageTags (seems a server 10.7.0 bug though, as MrTim couldn't reproduce) and some info like overview, which is needed so it's passed correctly to the next page.
Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.