jellyfin-vue icon indicating copy to clipboard operation
jellyfin-vue copied to clipboard

Chrome "Tap to search" should be disabled

Open Maxr1998 opened this issue 3 years ago • 13 comments

In some screens of the app, tapping on random elements in a mobile browser or the "installed" PWA brings up Chrome's "Tap to search" feature, which is useless and annoying. It should be disabled for the whole app.

Screenshots

Screenshot_20210212-110404.png

System (please complete the following information):

  • Platform: Android 11
  • Browser: Vivaldi 3.6.2178.40
  • Jellyfin Version: 10.7.0 unstable

Additional Context

I found this StackOverflow post when researching the issue, maybe it helps.

Maxr1998 avatar Feb 12 '21 10:02 Maxr1998

I remember we did this back in the time for web and it had a really bad reaction from people, so not sure how we could solve this.

ferferga avatar Feb 12 '21 11:02 ferferga

Fwiw, it doesn't show up on Jellyfin Web for me. Maybe it'd help to enable user-select: none; on such texts?

Maxr1998 avatar Feb 12 '21 12:02 Maxr1998

@Maxr1998 Perhaps Web using a media query to target mobile devices with it.

Are you running latest master though? We merged yesterday a commit that brings the meta-viewport settings from JF Web here and maybe those fixed this.

ferferga avatar Feb 12 '21 12:02 ferferga

I last updated a few days ago, so let me try it.

EDIT: nope, still happening on the latest unstable Docker image.

Maxr1998 avatar Feb 12 '21 12:02 Maxr1998

IMO, it's not something that should be changed as it happens everywhere. Just go to Wikipedia and you'll be able to select any word you wish. Also on the phone it isn't a problem to me (even though I noticed some zones can't be "grabbed" to scroll).

ThibaultNocchi avatar Feb 18 '21 17:02 ThibaultNocchi

@ThibaultNocchi We could disable selecting by default everywhere and make a class for enabling it, so we simply need to add the class to the item descriptions and so on where stuff can be selected.

ferferga avatar Feb 18 '21 18:02 ferferga

That's fair

ThibaultNocchi avatar Feb 18 '21 18:02 ThibaultNocchi

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

stale[bot] avatar Jun 03 '21 03:06 stale[bot]

Still relevant.

Maxr1998 avatar Jun 03 '21 08:06 Maxr1998

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

stale[bot] avatar Aug 02 '21 19:08 stale[bot]

Should maybe add a confirmed label, lol.

Maxr1998 avatar Aug 02 '21 21:08 Maxr1998

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

stale[bot] avatar Oct 02 '21 01:10 stale[bot]

No

Maxr1998 avatar Oct 02 '21 09:10 Maxr1998