jellyfin-vue icon indicating copy to clipboard operation
jellyfin-vue copied to clipboard

defining DEFAULT_SERVERS as Docker Enviroment Variable won't work

Open hofq opened this issue 1 year ago • 4 comments

Description of the bug

I cant get the DEFAULT_SERVERS variable to work.

If i define it i just have the prompt to enter my Server without any selection or button for the defined one

Steps to reproduce

  1. docker pull ghcr.io/jellyfin/jellyfin-vue:unstable.2022-08-10.c526428
  2. Run the Container with -e DEFAULT_SERVERS="https://my-instance.domain"
  3. No change

Expected behavior

I should be able to select my Server with 1 click, or don't even get to the selection screen

Logs

2022/08/12 00:24:34 [notice] 1#1: using the "epoll" event method
2022/08/12 00:24:34 [notice] 1#1: nginx/1.23.1
2022/08/12 00:24:34 [notice] 1#1: built by gcc 11.2.1 20220219 (Alpine 11.2.1_git20220219) 
2022/08/12 00:24:34 [notice] 1#1: OS: Linux 5.15.46-Unraid
2022/08/12 00:24:34 [notice] 1#1: getrlimit(RLIMIT_NOFILE): 40960:40960
2022/08/12 00:24:34 [notice] 1#1: start worker processes
2022/08/12 00:24:34 [notice] 1#1: start worker process 31
2022/08/12 00:24:34 [notice] 1#1: start worker process 32
2022/08/12 00:24:34 [notice] 1#1: start worker process 33
2022/08/12 00:24:34 [notice] 1#1: start worker process 34
2022/08/12 00:24:34 [notice] 1#1: start worker process 35
2022/08/12 00:24:34 [notice] 1#1: start worker process 36
2022/08/12 00:24:34 [notice] 1#1: start worker process 37
2022/08/12 00:24:34 [notice] 1#1: start worker process 38
2022/08/12 00:24:34 [notice] 1#1: start worker process 39
2022/08/12 00:24:34 [notice] 1#1: start worker process 40
2022/08/12 00:24:34 [notice] 1#1: start worker process 41
2022/08/12 00:24:34 [notice] 1#1: start worker process 42
2022/08/12 00:24:34 [notice] 1#1: start worker process 43
2022/08/12 00:24:34 [notice] 1#1: start worker process 44
2022/08/12 00:24:34 [notice] 1#1: start worker process 45
2022/08/12 00:24:34 [notice] 1#1: start worker process 46
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
10-listen-on-ipv6-by-default.sh: info: Getting the checksum of /etc/nginx/conf.d/default.conf
10-listen-on-ipv6-by-default.sh: info: /etc/nginx/conf.d/default.conf differs from the packaged version
/docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
/docker-ent

Screenshots

grafik

Platform

Linux

Browser

Firefox

Jellyfin server version

10.8.1

Additional context

I run both (Jellyfin & Jellyfin-vue-static) in Docker Containers on my Unraid-Host.

For my Jellyfin-vue i use the official unstable one from ghcr (Specific one in "Steps to Reproduce")

My Jellyfin-Server uses binhex/arch-jellyfin, but with manual entry of the Server everything works fine

hofq avatar Aug 11 '22 22:08 hofq

I'll investigate this, but that should easily be fixed. Do you happen to know a date where it worked?

I should also document this feature in the README

ThibaultNocchi avatar Aug 12 '22 18:08 ThibaultNocchi

Sadly no, i tried it the first time but it seems like a thing that should work normally so i assumed it was a bug

hofq avatar Aug 13 '22 00:08 hofq

Ok so I looked into it. It was implemented in #1698 and the environment variable needs to be specified at build time and not runtime.

So either it needs to be a new feature or not considered as needed, but at least the current one should work as expected.

The feature the way you're expecting it to work would be a little bit different to implement than currently. Once the docker image is built, it's all HTML and JS, so we'd need something like a JSON written at runtime into the container and that is fetched by the client. Honestly I don't really know, but that could be investigated for sure.

ThibaultNocchi avatar Aug 13 '22 13:08 ThibaultNocchi

Expect to force the client to automatically redirect the specified server by specifying the default server mode without requiring the user to enter it manually.

wolonggl avatar Sep 12 '22 14:09 wolonggl

As I understand it, there currently is no way to dynamically specify a default server with Docker variables. Instead, one has to build his own Docker image. Is that correct?

DesertCookie avatar Nov 24 '22 14:11 DesertCookie

@DesertCookie Yes, but this is already fixed in my local branch of #1812

ferferga avatar Nov 24 '22 15:11 ferferga

@ferferga So this will be fixed in the near future?

Otherwise I'll look into finally learning ho to build my own Docker images :).

DesertCookie avatar Nov 25 '22 09:11 DesertCookie

@DesertCookie Major stuff is already done (I'm already with the login screen working) but a lot is still pending and I need to focus in studies.

So no ETA, but hopefully before Christmas season.

ferferga avatar Nov 25 '22 09:11 ferferga

@ferferga No preassure. Thanks for the info.

We are looking into using Jellyfin to stream our indie movies to crowdfunders and would love to use the more modern look of the Vue UI. But of course we can't expect our backers to always type in the backend server URL.

DesertCookie avatar Nov 25 '22 09:11 DesertCookie

So no ETA, but hopefully before Christmas season.

is there a ray of hope at the end of the tunnel? Would be really cool if this would work

hofq avatar Mar 09 '23 22:03 hofq

@hofq Check the 5th point at #1812

ferferga avatar Mar 09 '23 22:03 ferferga

Wow! You made it! Thanks for your help and all the work that went into porting it to vue 3 🎉 @ferferga

hofq avatar Apr 03 '23 13:04 hofq