jellyfin-server-macos icon indicating copy to clipboard operation
jellyfin-server-macos copied to clipboard

[Issue]: macOs paths are incorrect

Open bestlem opened this issue 9 months ago • 9 comments

Please describe your bug

The default paths for macOS are not correct. See Helper/StartupHelpers.cs and Apple Documentation I think of the directory split as bing like XDG rather than windows but just in different place

The data directory (~/Library/Application Support/Jellyfin) is correct but others aren't

Definitely wrong Cache Directory should be ~/Library/Caches/Jellyfin - putting it there means that cleaning cache is consistent among apps and you don't have to hunt all over to find things taking up disk space and you can also easily ignore in backups Log Directory - ~/Library/Logs/Jellyfin - just consistent with other apps.

Arguably Config Directory - ~/Library/Preferences/Jellyfin

If strictly following Apple guidelines all the directories Jellyfin mentioned above should be org.jellyfin.jellyfin or org.jellyfin.jellyfin-server but many apps don't bother.

Reproduction Steps

Reading code

I note the mac app which is the one I got to tun still uses the old XDG paths.

Jellyfin Version

Weekly unstable (please specify)

if other:

10.9.1 from Mac installer

Environment

- OS: macOS Ventura
- Clients: web and jellyfin iOS app
- Browser: Orion

Jellyfin logs

[2024-05-26 17:07:54.721 +01:00] [INF] [1] Main: Jellyfin version: "10.9.2"
[2024-05-26 17:07:54.739 +01:00] [INF] [1] Main: Environment Variables: ["[JELLYFIN_LOG_DIR, /Users/mark/.local/share/jellyfin/log]"]
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: Arguments: ["/Applications/Jellyfin.app/Contents/MacOS/jellyfin.dll", "--webdir", "/Applications/Jellyfin.app/Contents/Resources/jellyfin-web", "--ffmpeg", "/Applications/Jellyfin.app/Contents/MacOS/ffmpeg", "--datadir", "/Users/mark/.local/share/jellyfin"]
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: Operating system: "Darwin 23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:16:51 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T8103"
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: Architecture: Arm64
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: 64-Bit Process: True
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: User Interactive: True
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: Processor count: 8
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: Program data path: "/Users/mark/.local/share/jellyfin"
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: Log directory path: "/Users/mark/.local/share/jellyfin/log"
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: Config directory path: "/Users/mark/.local/share/jellyfin/config"
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: Cache path: "/Users/mark/.local/share/jellyfin/cache"
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: Web resources path: "/Applications/Jellyfin.app/Contents/Resources/jellyfin-web"
[2024-05-26 17:07:54.740 +01:00] [INF] [1] Main: Application directory: "/Applications/Jellyfin.app/Contents/MacOS/"

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

bestlem avatar May 27 '24 10:05 bestlem