jellyfin-roku icon indicating copy to clipboard operation
jellyfin-roku copied to clipboard

Published 20 hours ago • verified publisher icon jellyfin

Update Alpha menu - refactor, bugfix, and QOL updates

Open cewert opened this issue 1 year ago • 7 comments

This converts the alpha menu to use the correct styling for vars, it moves the mic icon inside the alpha node, fixes an edge case bug, and adds some quality of life improvements.

Changes

  • Refactor Alpha.bs and all files that use it to use lowerCamelCase for all var names
  • Move the mic icon from ItemGrid, MovieLibraryView, and MusicLibraryView and put it inside the Alpha component. ~~Also removes the mic text completely~~
    • Moved the mic icon and mic text to the overhang to match the tvguide page (except for music library which hides the overhang)
    • The tvguide/itemgrid was the only thing using the mic text (and reusing the mic icon). I am now creating the mic icon and text nodes as needed for the livetv guide view.
  • Convert mic icon from a Button to a Poster node
    • It was difficult to reproduce in the first place but I haven't been able to reproduce #1525 since making this change
  • Keep focus on alpha menu after selecting a letter
    • EDIT: I'm keeping focus on alpha menu now whenever it is active no matter what. Including after using the voice filter option
  • When a user selects the same letter that is already focused, remove the current filter instead of doing nothing
  • Move logic to show mic icon into Alpha.bs
  • When using the voice search/filter feature, if the users search is for a single character, select the corresponding option on the alphamenu i.e. saying "Z" will select "Z" on the alhpamenu. saying 3 will select "#" etc.

Issues

Fixes #1297 Fixes #1526 Fixes #1527 Fixes #1528

Note: there was one thing I tried to fix but couldn't figure out how:

  • When the alpha menu is not focused, there is a wide "focused" overlay that shows up on top of it although it is hard to see with the naked eye. Here is a screenshot after first load of the movie library (notice the overlay around #) image

cewert avatar Nov 27 '23 15:11 cewert

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

jellyfin-bot avatar Nov 30 '23 01:11 jellyfin-bot

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

jellyfin-bot avatar Jan 08 '24 01:01 jellyfin-bot

In my Movie library, in Presentation view, I clicked a letter and it threw an error on line 737 m.spinner.visible = true

image

1hitsong avatar Jan 13 '24 18:01 1hitsong

hah so the reason I missed that crash was because of my movie library being bugged (it would load using the itemgrid instead of the movie specific grid). Apparently that fixed itself recently because I can reproduce this crash. Great timing 😆

cewert avatar Jan 14 '24 01:01 cewert

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

jellyfin-bot avatar Feb 04 '24 01:02 jellyfin-bot

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

jellyfin-bot avatar Feb 06 '24 17:02 jellyfin-bot

This also likely fixes #1297

1hitsong avatar Feb 19 '24 12:02 1hitsong

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

jellyfin-bot avatar Mar 13 '24 01:03 jellyfin-bot

This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired.

jellyfin-bot avatar Mar 21 '24 01:03 jellyfin-bot

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

jellyfin-bot avatar May 03 '24 01:05 jellyfin-bot

This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired.

jellyfin-bot avatar May 10 '24 01:05 jellyfin-bot