jellyfin-plugin-tvdb icon indicating copy to clipboard operation
jellyfin-plugin-tvdb copied to clipboard
verified publisher icon jellyfin

Replace PersonType with PersonKind

Open Maeur1 opened this issue 2 years ago • 2 comments

I seem to be getting some errors on my end of the pluging saying these fields are strings, but I noticed in march these were changed to PersonKinds instead.

https://github.com/jellyfin/jellyfin/blob/master/Jellyfin.Data/Enums/PersonKind.cs

The commit looks like it was from 6 months ago, so I figured to try and fix the plugin.

Not sure how to test if this works (other than making the plugin and installing it myself)

Maeur1 avatar Sep 23 '23 11:09 Maeur1

Thank you for the PR. unstable versions of Jellyfin aren’t supported so I am going to mark this PR as blocked until 10.9 is released

crobibero avatar Sep 23 '23 13:09 crobibero

Thank you for the PR. unstable versions of Jellyfin aren’t supported so I am going to mark this PR as blocked until 10.9 is released

Omg you are completely right! I forgot I am running unstable and hence the plugin wasn't working for me!

I guess I'll give it an install with this and update the PR if anything else breaks with it on the latest unstable

Maeur1 avatar Sep 24 '23 05:09 Maeur1

This has been fixed in the greater 10.9 PR. Thank you for your contribution

crobibero avatar May 13 '24 17:05 crobibero