jellyfin-plugin-anidb icon indicating copy to clipboard operation
jellyfin-plugin-anidb copied to clipboard

Published 20 hours ago • verified publisher icon jellyfin

Verify that Fuzzy matching is working as intended, and add tests

Open oddstr13 opened this issue 1 month ago • 2 comments

It is unclear to me whether this code works as expected or not. Review that the generated regex actually is what's intended, and add tests both for the regex generation and the fuzzy matching.

In particular, this looks suspect to me, I would expect the output of this to be ((OVA)|(((OVA)|(OAD)))), due to sequential .replace. https://github.com/jellyfin/jellyfin-plugin-anidb/blob/dd298960b7c211c9f54ecd3502bf677664acf863/Jellyfin.Plugin.AniDB/Providers/equals_check.cs#L86-L87

https://github.com/jellyfin/jellyfin-plugin-anidb/blob/dd298960b7c211c9f54ecd3502bf677664acf863/Jellyfin.Plugin.AniDB/Providers/equals_check.cs#L54-L94

oddstr13 avatar May 20 '24 22:05 oddstr13