jellyfin-media-player icon indicating copy to clipboard operation
jellyfin-media-player copied to clipboard

Published 20 hours ago • verified publisher icon jellyfin

Change to Qt 6

Open nvllsvm opened this issue 10 months ago • 9 comments

Not ready for release.

Blockers:

  • https://github.com/jellyfin/jellyfin-media-player/issues/537

nvllsvm avatar Apr 19 '24 18:04 nvllsvm

I'm debating where a final Qt 5 release should be made before this gets merged. Mainly to bring in the mpv 0.38.0 compatibility fix.

@iwalton3 Thoughts?

nvllsvm avatar Apr 19 '24 18:04 nvllsvm

This branch is fully unsuitable for release, and releasing it would currently add no value to the ecosystem. Qt6 does not give us anything in a world where 5.15.11 exists. The most reasonable way forward is to ride Qt5 until compat loses support. Within that time we should have built an OSC per #537 or the related Qt Bug will have been fixed. Then we can port to the native API and at that point we can discuss sunsetting the Qt5 build. Migrating now would be way beyond premature imho.

sevenrats avatar Apr 20 '24 16:04 sevenrats

This needs to be held until we either:

  • reach feature parity with the 5.x branch
  • are forced to switch to it because the ecosystem around it breaks

Notably the rendering pipeline is completely busted and we're using a UI cutout workaround to make it even slightly work that kills all overlay menus and trick play in the player.

iwalton3 avatar Apr 20 '24 16:04 iwalton3

some of these other changes are very good @nvllsvm, do you intend to open a new pr with them?

sevenrats avatar Apr 20 '24 16:04 sevenrats

@sevenrats Took a first pass and added a few of those changes to https://github.com/jellyfin/jellyfin-media-player/pull/603

nvllsvm avatar Apr 20 '24 18:04 nvllsvm

Would you please add these ubuntu packages to the list of required packages for building for QT6 in Readme.md? qt6-5compat-dev qt6-base-dev qt6-base-private-devqt6-declarative-dev qt6-webchannel-dev qt6-webengine-dev

satmandu avatar May 03 '24 15:05 satmandu

This would help with the message

Uses an end-of-life runtime
The runtime used by this app is no longer receiving security updates

from https://flathub.org/apps/com.github.iwalton3.jellyfin-media-player

kenden avatar May 06 '24 10:05 kenden

@kenden I suspect this has to do with the flatpak itself. Qt5 is not EoL for another 12 months, so, whatever runtime you have that is outdated is probably unrelated to this issue.

sevenrats avatar May 06 '24 10:05 sevenrats

Thanks @sevenrats I think this is actually described in this issue: https://github.com/flathub/com.github.iwalton3.jellyfin-media-player/issues/41

kenden avatar May 06 '24 11:05 kenden