jellyfin-kodi icon indicating copy to clipboard operation
jellyfin-kodi copied to clipboard

Fix websocket automatic reconnection

Open smcmnz opened this issue 1 year ago • 3 comments

Changes the reconnection approach to use the reconnect function of the websocket-client library. The current approach throws an error but does not reconnect.

After reconnection a small delay was needed before the session capabilities are registered otherwise the client will not appear as user controllable.

Resolves #797

smcmnz avatar Jan 27 '24 00:01 smcmnz

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 21.52%. Comparing base (e478e4b) to head (e234fb4). Report is 9 commits behind head on master.

:exclamation: Current head e234fb4 differs from pull request most recent head 3d24ca8. Consider uploading reports for the commit 3d24ca8 to get more accurate results

Files Patch % Lines
jellyfin_kodi/jellyfin/ws_client.py 0.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
+ Coverage   21.50%   21.52%   +0.02%     
==========================================
  Files          63       63              
  Lines        8546     8537       -9     
  Branches     1572     1571       -1     
==========================================
  Hits         1838     1838              
+ Misses       6684     6675       -9     
  Partials       24       24              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 06 '24 11:02 codecov[bot]

Is there something we can do to push this fix fwd?

glogiotatidis avatar Feb 22 '24 13:02 glogiotatidis

Just discovered Jellyfin (moving away from Plex) and this little issue is driving me crazy :) Any timeline on when this issue will be solved?

IosifZ avatar Mar 22 '24 13:03 IosifZ