jellyfin-kodi icon indicating copy to clipboard operation
jellyfin-kodi copied to clipboard

Add setting to force transcode Dobly Vision

Open fezster opened this issue 1 year ago • 2 comments

Added setting to allow force transcode of Dolby Vision files.

This PR includes the hdr metadata fix.

On Firestick 4k Max, it is useful to be able to force a transcode with tone mapping for Dolby Vision files, otherwise certain profiles / combination of profiles just show a blank screen. I've had to force a transcode to h264 to achieve this.

fezster avatar Jan 09 '24 11:01 fezster

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 09 '24 11:01 sonarqubecloud[bot]

I haven't had a chance to look through everything closely, but the main issue I see is that you shouldn't be modifying all of the language files. That's going to break our translation service. You should only edit the english files, and the other languages will be updated automatically as translations come in

mcarlton00 avatar Mar 07 '24 18:03 mcarlton00

@mcarlton00's review comment about modifying language files has not been addressed.

oddstr13 avatar Jun 10 '24 08:06 oddstr13