jellyfin-kodi
jellyfin-kodi copied to clipboard
Cinema mode not working only intro plays
Describe the bug
So I've tried to use the cinema mode, and it only seems to play the intro, it never continues to play the movie/show
To Reproduce
- Install intros plugin on Jellyfin
- Enable Cinema mode in Jellyfin settings on Kodi
- Play movie or show
- Intro now plays
- When intro is done nothing else is playing and it just returns to the menu
Expected behavior
Play the intro then continue to play the movie/show after
Logs
System (please complete the following information):
- OS: Android TV
- Jellyfin Version: 1.0.7.6
- Kodi Version: 19.1
- Addon Version: 0.7.4+py3
- Playback Mode: Add-On
Side note: I think I have the same issue with android Jellyfin and external player but I need to do more testing. I definitly have the issue you describe for kodi though. I'm not sure how it works but I believe each individual client need to have support for the intro plugin for it to work properly.
I can confirm that this is indeed an issue, no idea of what changed to cause it, however. Workaround is to disable cinema mode in the addon.
As an update: we currently have no method of playing more than one file, it just plays whatever is first up in the queue. https://github.com/jellyfin/jellyfin-kodi/blob/d69f96f9f3a9aacaf5a95d83f8857eae23c4676e/jellyfin_kodi/objects/actions.py#L78-L79
I tried copying the playback commands used in JellyCon because intros work fine there (adding things to a playlist and then xbmc.Player().play(playlist)
), and it instead caused Kodi to completely lock up and eventually crash back to the desktop. So it looks like we're going to have to rework the playback code somehow. In the meantime, we should probably change the settings file to have cinema mode off by default on new installs.
I’m a novice but I’ll see if I can find a function from this kodi addon: https://github.com/CinemaVision/script.cinemavision which also handles pre rolls that might help.
Ok so i've done some digging, it looks like the fuction they use is on line 887 of https://github.com/CinemaVision/script.cinemavision/blob/master/lib/experience.py
It's calling quite a few defined variables and other functions so might be a bit to tease apart, but seems relatively straight forward. It's probably a bit beyond me given I'm not familiar with the code base or how this addon grabs the intros and video file, but if I ever get some spare time, I'll try and reason it out if no-one else does. I will say, I AM a novice, I just know enough to be dangerous (if not effective ha).