jellyfin-androidtv icon indicating copy to clipboard operation
jellyfin-androidtv copied to clipboard

Intro support for shows

Open Mis1ify opened this issue 1 year ago • 7 comments

Describe the feature you'd like

Hi, it seems like the code is written to play intros only for movies, could you add an option to play this with shows too?

More info: https://github.com/BrianCArnold/jellyfin-plugin-intros/issues/10

Mis1ify avatar May 22 '23 14:05 Mis1ify

This should be possible with #1057. Right now we cannot easily add this functionality for TV shows. If we did, the intro would play before each episode instead of just the first one.

nielsvanvelzen avatar May 23 '23 20:05 nielsvanvelzen

Okay I get it. I would like that anyway but I understand that for some people intro for each episode would be irritating.

Mis1ify avatar May 24 '23 04:05 Mis1ify

When the playback rewrite will be completed? I see that it started back in 2021.

Mis1ify avatar May 24 '23 04:05 Mis1ify

https://jellyfin.org/docs/general/faq#when-will-release-x-happen-when-will-feature-x-be-available

nielsvanvelzen avatar May 24 '23 07:05 nielsvanvelzen

This should be possible with #1057. Right now we cannot easily add this functionality for TV shows. If we did, the intro would play before each episode instead of just the first one.

I would also be okay with this. I’m using a pre-rolls plugin and this would just be for any one of a series of 5-10 second “production logos” I’ve made for my server.

SmaMan avatar Jul 27 '23 01:07 SmaMan

This should be possible with #1057. Right now we cannot easily add this functionality for TV shows. If we did, the intro would play before each episode instead of just the first one.

Maybe I'm missing something but I've just added the same code as DEFAULT case on top of EPISODE case and it works as I think is the perfect behaviour: No matter what episode you select (first one or any other one) intro will be played once before the episode and the rest of the queue will play next without intro. This is the way it works in both webclient and android client.

I'm talking about editing PlayBackHelper.java line ~50 to start the EPISODE case with the async call to get the intro; hook up the onResponse event; add the intro to items list, then add mainItem, then the rest of the code as it is to queue the subsequent episodes.

javikas avatar Nov 20 '23 17:11 javikas

This should be possible with #1057. Right now we cannot easily add this functionality for TV shows. If we did, the intro would play before each episode instead of just the first one.

Maybe I'm missing something but I've just added the same code as DEFAULT case on top of EPISODE case and it works as I think is the perfect behaviour: No matter what episode you select (first one or any other one) intro will be played once before the episode and the rest of the queue will play next without intro. This is the way it works in both webclient and android client.

I'm talking about editing PlayBackHelper.java line ~50 to start the EPISODE case with the async call to get the intro; hook up the onResponse event; add the intro to items list, then add mainItem, then the rest of the code as it is to queue the subsequent episodes.

This is indeed the desired behaviour and how it is on jellyfin-web right now

PCJones avatar Jan 28 '24 19:01 PCJones