jellyfin-androidtv icon indicating copy to clipboard operation
jellyfin-androidtv copied to clipboard

Published 20 hours ago • verified publisher icon jellyfin

Add RTL Support

Open hadicharara opened this issue 2 years ago • 14 comments

Changes I added RTL support for this app. Most of the work was clicking the refactor button in Android Studio. Other parts included properly formatting numbers (to support Eastern Arabic Numbers, for example), rewriting certain layouts (like legacy card image layout) and adding more constraints to others.

Issues None

hadicharara avatar Jul 12 '22 17:07 hadicharara

I am open to any feedback!

hadicharara avatar Jul 12 '22 17:07 hadicharara

Sorry for the wait. I'm currently busy preparing the 0.14 release and this PR might break some things so it will be added for 0.15 to give us some more time to test it. From a quick glance it looks fine but I'll properly review it in the coming weeks.

nielsvanvelzen avatar Jul 22 '22 19:07 nielsvanvelzen

No worries mate. Take your time.

hadicharara avatar Jul 23 '22 04:07 hadicharara

I'm looking into it.

hadicharara avatar Aug 09 '22 13:08 hadicharara

It's weird as I don't get the same result: image Did you do anything in particular to see those rectangular opaque shadows?

hadicharara avatar Aug 09 '22 15:08 hadicharara

It only showed in the browsing screen (so when in a library)

nielsvanvelzen avatar Aug 09 '22 17:08 nielsvanvelzen

I couldn't reproduce it. I am guessing maybe it has to do with your non-stock theme. Should I just eliminate shadows going down?

hadicharara avatar Aug 09 '22 17:08 hadicharara

Also are we sure these are shadows?

hadicharara avatar Aug 09 '22 17:08 hadicharara

I am guessing maybe it has to do with your non-stock theme.

It's the default theme

Also are we sure these are shadows?

Partially background, partially shadow

nielsvanvelzen avatar Aug 09 '22 18:08 nielsvanvelzen

I meant your OS theme. The title progress bar and the tick don't look the same on my machine. Honestly, I couldn't reproduce it so I don't know what to do.

hadicharara avatar Aug 11 '22 19:08 hadicharara

Testing was done with the Android emulator (Android 12) with nothing changed.

nielsvanvelzen avatar Aug 13 '22 08:08 nielsvanvelzen

I tried both Android 12 TV emulator images available in Android Studio. Neither look like your screenshot. They looked more like mine. There was a light blue circle tick on the cards and no shadow. I'm sorry, I couldn't reproduce the issue. I don't know what to do.

hadicharara avatar Aug 13 '22 15:08 hadicharara

Did some more testing and apparently this only happens when the library is set to align items vertically, weirdly enough.

nielsvanvelzen avatar Aug 13 '22 16:08 nielsvanvelzen

Thank you! I managed to reproduce it! I'll investigate the root cause.

hadicharara avatar Aug 13 '22 16:08 hadicharara

It should be fixed now.

hadicharara avatar Aug 18 '22 22:08 hadicharara