jellyfin-android
jellyfin-android copied to clipboard
ExoPlayer pinch to zoom occasionally causes subtitles to be cut off
Describe the bug
When using gesture to scale video, subtitles don't move so they aren't always visible To Reproduce
- Play video with subtitles using exoplayer
- Use pull gesture to scale movie
- You see that subtitles aren't working properly
Expected behavior Subtitles to work normally
Logs
Screenshots
System (please complete the following information):
- App version: works this way on every version
- Android version: android 11
- Device manufacturer and model: samsung galaxy s20 FE
- Jellyfin server version: 10.7.5
- The type of video player implementation used: exoplayer
Additional context
Known issue, zooming the player view also moves subtitles. This is because subtitles are exactly overlaid on top of the player view, as they can position themselves in more advanced subtitle formats.
There is however a method to set the position for unpositioned subtitle lines, we should probably use that.
See here for more info: google/ExoPlayer#8293 and https://github.com/google/ExoPlayer/issues/7243#issuecomment-614651130
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.
Experiencing the same on OnePlus 9 pro (Android 13) Jellyfin app version 2.6.0. There are these 2 players Next Player and Just Video Player (both open source using Exoplayer) they don't have this problem.