Timeouts may not be upheld
It's come to my attention that the Timeouts given to HttpClient (CancellationTokens) only apply to the actual request, and up till the response is "ready". Once the response is being read (as a Stream), the timeouts no longer apply.
We should ensure that our Timeouts work.
I'm having this problem
What are you experiencing?
What are you experiencing?
I've been using your TMDBLib library for the last few years and it has been very good for me in that long period, but in the last few weeks the GetMovieAsync, GetTvShowAsync, DiscoverMoviesAsync and DiscoverTvShowsAsync methods (I only use these at the moment) have been slow in responses and sometimes returns null values, I still can not investigate why this is occurring but I believe it is related to the http request, it gets stuck for a long time even if X-RateLimit is OK
Hmm. Certainly sounds like it. The result of the method is null?
If it's an error code of sorts, and the result is null - we should probably throw exceptions instead.. Feel like we've been over this before :O.
Would you like a timeout for the entire request, or a timeout for reading and writing, or something else entirely?