Swiftfin icon indicating copy to clipboard operation
Swiftfin copied to clipboard

Device ID keeps changing on ATV

Open rwjack opened this issue 2 years ago • 1 comments

Describe the bug

Hey,

I'm using Swiftfin on ATV, and I'm also using the Home Assistant Jellyfin integration.

The main issue I'm having is the creation of duplicate media players in the Home Assistant integration.

The code owners over at the HA Jellyfin integration identified this as a client issue.

To quote:

Looking at your diagnostics we can see that the two devices that you report have different device_id, hence they are created as separate devices in Home Assistant by the integration.

From https://github.com/jellyfin/Swiftfin/blob/eb17300061315ff310749871f5b79032385ba55a/Shared/Services/NewSessionManager.swift#L115 we can see that the device ID is created from the platform and vendorUUIDString. These are defined here: https://github.com/jellyfin/Swiftfin/blob/main/Shared/Extensions/UIDevice.swift

The vendorUUIDString is based on a identifierForVendor constant defined by Apple here: https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierforvendor Which states "The value of this property is the same for apps that come from the same vendor running on the same device. A different value is returned for apps on the same device that come from different vendors, and for apps on different devices regardless of vendor."

Somehow this does not hold true for the SwiftFin app.

Any ideas here on what could be happening?

Application version

1.0.1 (70)

Where did you install the app from?

App Store

Device information

AppleTV 4K gen3

OS version

tvOS 17.1

Jellyfin server version

10.8.12

rwjack avatar Dec 16 '23 09:12 rwjack

Same problem

AppleCarmine avatar Sep 06 '24 20:09 AppleCarmine