Swiftfin icon indicating copy to clipboard operation
Swiftfin copied to clipboard

Update JellyfinAPI

Open LePips opened this issue 3 years ago • 1 comments
trafficstars

This PR servers as the (long) transition to the new async/await provided in the new JellyfinAPI.

I am developing this transition with the following steps:

  1. remove jellyfin-sdk-swift
  2. have a local copy of jellyfin-sdk-swift at version 0.1.0, rename folder to jellyfin-sdk-swift-legacy
  3. rename the target to JellyfinAPILegacy
  4. import as local package and update imports to JellyfinAPILegacy
  5. add jellyfin-sdk-swift at version 0.2.0

This allows incremental updates instead of having to replace all of the calls at once before a successful build.

  • [ ] make async/await wrappers
  • [ ] inject some sort of session object into environment
    • this helps with resetting the app view on logout
  • [ ] ActivityIndicator replacement
  • [ ] refactor view models error handling
  • [ ] replace calls...
    • might require slight adjustments to other views/callsites that require a full URL, like ImageView

LePips avatar Aug 18 '22 17:08 LePips

After starting this a bit, I'm not so inclined to expedite this so that other features can be worked on. This will be in the background.

Edit: I'll actually wait until CreateAPI has sorting path parameters and paths organization, this will be very valuable now instead of rewriting later on when these are added.

LePips avatar Aug 22 '22 20:08 LePips

Will be done in #593.

LePips avatar Dec 08 '22 17:12 LePips