Swiftfin
Swiftfin copied to clipboard
jellyfin
Implement mpv Player
I think VLCkit is really good, too. But it'd be better to change to a better performance and more scalable mpv, so I'm going to leave an issue.
As far as I know, plex is also using mpv. And https://github.com/jellyfin/jellyfin-media-player too.
Of course, I'm currently completely ignorant of mpv. lol
Actually, building mpv for iOS isn't officially supported and looks complicated. We shouldn't even consider it.
https://github.com/mpv-player/mpv/issues/5902
Actually, building mpv for iOS isn't officially supported and looks complicated. We shouldn't even consider it.
That's too bad.
What performance issues do you have with VLCKit?
When I changed the time scroll bar(?) offset when Playing a specific video(MPEG-4, AVI), I felt that it was much slow than other video players. (It's working after 5 seconds.) And there is a crash when playing a video including a specific subtitle(.kor.srt).
But seeing how it works normally through the VLCPlayer in the App Store, There seems to be a problem with the implementation of Swiftfin. In the future, I'll create issues related to this problems again if the same occurs after VideoPlayer refactoring. (Not about "using mpv")
I may want to investigate some time as I'm interested in attempting to build for iOS/tvOS with some sources:
- https://github.com/ldwardx/mpv-build-mac-iOS
- https://github.com/mpv-player/mpv/issues/8362
- https://github.com/mpv-player/mpv/issues/5331
At first I wouldn't look at entirely replacing VLCKit but instead creating another player based on mpv and then have the option to render with either of them.
Here's also something for the future: ~~https://github.com/manhpham90vn/MPVPN~~
Edit: oops
Gonna reopen as now this seems like something we need to do and eventually replace (or demote) VLCKit
I've been able to build the static libraries and connect them to a test project, however mpv isn't built to just be a drop-in implementation like VLCKit. Instead, everything has to be made from scratch. Luckily, iina is something to at least reference.
Hi @LePips, hope you're doing well, can you share the step to build for iOS, i'm trying to do so, but i'm facing an error regarding POSIX, i asked the question here few hour ago, but you may know how to fix as you succeed building it, Thank you :)
I haven't gotten to this for a very long time so I can't help you regarding this, sorry.
There are a few projects on GitHub if you search "mpv build iOS" to build mpv on iOS to get static libraries. I don't remember which one works.
I've been exploring the codebase and have mpv (+ffmpeg, libssl, harfbuzz, etc.) building via static xcframeworks, so far only testing that I can get a pointer back from mpv_create(). Would anyone be interested in a PR adding a basic mpv player view behind an experimental flag?
@LePips I see you're in the middle of a video player refactor, I think the basic work of getting a simple MPV player view shouldn't conflict too much with that and should be simple enough to resolve conflicts after your branch is merged.
Thanks for the interest! I have also been able to build mpv and have started an equivalent MPVUI project to VLCUI in private until it's ready, using iina as reference. I haven't gotten much into it because I'm doing a lot of work here. Implementing mpv here will be using that MPVUI project.
Essentially the video playing/rendering is outside of this project and should be the concern of VLCUI/MPVUI. With the work that I have done, it will be pretty trivial to allow switching the video playing layer. mpv is capable of a lot more, so I will most likely remove VLCUI because of its missing features and will be less of a concern for this project.
Awesome! If you want any help feel free to open up the project or reach out. Excited to see mpv supported by Swiftfin.
Yattee is also using mpv. https://github.com/yattee/yattee
And I just discovered following project. Could be a good starting point. https://github.com/cxfksword/MPVKit
