croodle icon indicating copy to clipboard operation
croodle copied to clipboard

Doesn't warn about partially filled out times

Open doobry-systemli opened this issue 5 years ago • 6 comments

When entering times for the selected dates, there's two usability bugs:

  1. Partially entered times are accepted as valid but withdrawn in next step
  2. Selecting "Copy and paste times of first day to all other" with partially entered times doesn't create a warning, even though nothing happens

croodle_datepicker

doobry-systemli avatar Nov 01 '19 14:11 doobry-systemli

This is a tough one. Browser does not set input's value for an <input type="time"> if user enters only parts of a time. I'm not sure if there is any way to distinguish if the input is empty or partly entered. https://jsbin.com/pikabowoyo/edit?html,js,output

jelhan avatar Nov 01 '19 15:11 jelhan

I'm not sure how the following would relate to the UX, but would using multiple fields work?

geor-g avatar Nov 01 '19 16:11 geor-g

Hm. Even though I'm a big fan of using the browser native input elements as much as possible. Together with https://github.com/jelhan/croodle/issues/238 this kind of begs the question whether to switch to some form of custom element for date and time inputs. :crying_cat_face:

sappor0 avatar Nov 01 '19 16:11 sappor0

I've asked on StackOverflow and got a solution after a few minutes. The input is invalid if partially filled. :tada:

jelhan avatar Nov 02 '19 07:11 jelhan

Reopen as the fix does not work in Firefox on Desktop. :disappointed:

User interfaces of mobile Chrome, mobile Firefox and Edge prevent filling in a partially time. Safari (Desktop) and IE 11 does not support <input type="time">. Haven't had the chance to test iOS Safari yet.

jelhan avatar Nov 03 '19 17:11 jelhan

Yeah, just experienced the same: it doesn't work as intended in Firefox on Desktop :disappointed:

doobry-systemli avatar Nov 06 '19 22:11 doobry-systemli