Jeldrik Hanschke

Results 431 comments of Jeldrik Hanschke

Ember Bootstrap needs this functionality as well. Ember Bootstrap supports different Bootstrap versions in parallel. `@embroider/macros` are used to eliminate code paths only required for other Bootstrap versions. `ownConfig` is...

Maybe we should revisit #109 and convert the value to a string explicitly?

Thanks for reporting. Do you have time providing a PR, which 1) fixes the issue and 2) adds test coverage for SVG usage?

It has been fixed for SVG elements in #235. While working on the fix, we noticed that it is broken for `` element as well. A fix for that one...

Good catch. Need to add guards for FastBoot at all places at which we use either `window.addEventListener` or `window.localStorage`. [FastBoot documentation for addon author](https://ember-fastboot.com/docs/addon-author-guide#how-to-fix-it) discusses two approaches: 1. Optional chaining...

I just noticed that FastBoot support is not as simple as expected. The decorator uses a global cache for local storage values: https://github.com/jelhan/ember-local-storage-decorator/blob/f80d55e0379a3ea285eb19500e3f2a454fd43bd3/addon/index.js#L3-L4 In FastBoot many application instances may run...

> If I'm interpreting the [documentation for the submit action](https://www.ember-bootstrap.com/api/classes/Components.Form.html#method_submit) correctly, my approach should (or could?) work. Yes. It should work. Do you have time to investigate why it is...

Should be covered by [ember-template-lint/no-outlet-outside-route](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-outlet-outside-routes.md), isn't it?

Please provide a reproduction. The [demo app](https://www.ember-bootstrap.com/components/navbars) seems to work as expected.

> Still working on these fixes. One question--when the decorator is used without arguments (`isDirectDecoratorInvocation`), TypeScript expects the decorator return type to be `void` or `any`. However for that condition...