minima icon indicating copy to clipboard operation
minima copied to clipboard

SASS is deprecating the ability to use a / (slash) for division.

Open CodeAsm opened this issue 2 years ago • 18 comments

During site deployment, i get deprecation warnings. Similiar to the suggested fix here: https://github.com/jekyll/minima/pull/705 seems to indicate the same issue im having

remote: 
remote: Recommendation: math.div($spacing-unit, 2) or calc($spacing-unit / 2)
remote: 
remote: More info and automated migrator: https://sass-lang.com/d/slash-div
remote: 
remote:     ╷
remote: 134 │   padding-left: $spacing-unit / 2;
remote:     │                 ^^^^^^^^^^^^^^^^^
remote:     ╵
remote:     ../../../../minima-2.5.1/_sass/minima/_base.scss 134:17  @import
remote:     minima.scss 48:3                                         @import
remote:     /home/[snip]/git/site/assets/main.scss 1:9       root stylesheet
remote: DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

running the suggested command wont work remote, as these codes are inside the downloaded template. I would love to get rid of minima, but seeing its a default template and pretty minimal, this needs fixing for more people. Whatever a default would be, more people stumble upon this problem right?

CodeAsm avatar Feb 06 '23 17:02 CodeAsm

I've been getting the same:

190 │     padding-left: $spacing-unit / 2;
    │                   ^^^^^^^^^^^^^^^^^
    ╵
    ../../../../minima-2.5.1/_sass/minima/_base.scss 190:19  @content
    minima.scss 38:5                                         media-query()
    ../../../../minima-2.5.1/_sass/minima/_base.scss 186:3   @import
    minima.scss 48:3                                         @import
    /home/charlie/g/cooksey.io/assets/main.scss 1:9          root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacing-unit, 3) or calc($spacing-unit / 3)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
244 │     padding: ($spacing-unit / 3) ($spacing-unit / 2);
    │               ^^^^^^^^^^^^^^^^^
    ╵
    ../../../../minima-2.5.1/_sass/minima/_base.scss 244:15  @import
    minima.scss 48:3                                         @import
    /home/charlie/g/cooksey.io/assets/main.scss 1:9          root stylesheet
Warning: 6 repetitive deprecation warnings omitted.

cdcooksey avatar Feb 22 '23 11:02 cdcooksey

@cdcooksey This has been addressed on the master. There are no plans to ship a release in the near future.

You have multiple options at your disposal:

  • The root cause of these warnings are from jekyll-sass-converter-3.0.0 which uses a new implementation of Sass. You can edit your Gemfile to use only jekyll-sass-converter-2.x. Or you can continue using the v3 of sass-converter but disable these warnings via your config file:
    # _config.yml
    
    sass:
      quiet_deps: true
    
  • Another route is to use the unreleased version of the theme directly from the GitHub repo using the jekyll-remote-theme. However, do note that the unreleased changes include numerous breaking changes and will continue to incorporate more breaking changes until release.

ashmaroli avatar Feb 22 '23 12:02 ashmaroli

Or you can continue using the v3 of sass-converter but disable these warnings via your config file

Thank you providing a workaround, it was annoying to see the warning on every build. Looking forward to the next release!

rockstorm101 avatar Feb 23 '23 15:02 rockstorm101

Appreciate your clear response @ashmaroli. I have been searching for an answer on this issue.

k4u5hik avatar Feb 24 '23 23:02 k4u5hik

This has been bothering me as well until finding this. Not being familiar with Jekyll or Sass much then presented with immediate errors first run with bundle exec jekyll serve is unnerving. Add maintenance cost immediately. Coders love it when things are failing and flimsy and need fixing from the get go. Right? Seems to me there should be a release. This is a mental blocker of an issue that doesn't need to confront every new user, instills lack of trust in the product immediately and looks bad.

Just my 2-cents. I do love Jekyll. Seriously. A lot.

johnnypeck avatar Mar 02 '23 22:03 johnnypeck

~~This seems perfect for a patch-level release, considering it causes deprecation warnings unless suppressed.~~

Ah, there are breaking changes currently merged into main. Considering there is an easy workaround, it makes more sense why creating a patch release for this is a low priority. It would have been a good idea to keep those breaking changes out of main until they were ready to ship, but that's a lesson for the future.

joshbuker avatar Mar 05 '23 18:03 joshbuker

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

jekyllbot avatar May 05 '23 19:05 jekyllbot

@jekyllbot https://drewdevault.com/2021/10/26/stalebot.html

joshbuker avatar May 06 '23 01:05 joshbuker

We have temporarily hidden the warnings in our build (raspberrypi/documentation#2866) but would definitely appreciate an upstream fix. Yes, it's not crucial, but it is a horrible user experience.

aallan avatar May 21 '23 10:05 aallan

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

jekyllbot avatar Jul 21 '23 11:07 jekyllbot

This issue has been automatically marked as stale because it has not been commented on for at least two months.

This is a dumb reply to keep @jekyllbot happy. The issue still persists, and is relevant.

rockstorm101 avatar Jul 21 '23 19:07 rockstorm101

It seems to be in only one place, why not checkout the last release, make the change, and then do a patch release from there? Then it can be fixed on main later? Git's flexible, this shouldn't be that big of a deal to fix.

GinoMan avatar Aug 13 '23 04:08 GinoMan

Wasn't this addressed by #700?

agregen avatar Sep 09 '23 14:09 agregen

Any plan still for a new release with the fixes?

tthvo avatar Sep 20 '23 05:09 tthvo

Wasn't this addressed by #700?

Yeah looks like it. Id prever a new release. whats the issue with making new releases? you dont experiment in main, that's where branches are for.

CodeAsm avatar Sep 30 '23 15:09 CodeAsm

The last release was in 2019, 4 years ago...

Is Minima in need of a maintainer?

I would normally volunteer, but I'm already hilariously behind on maintaining other projects.

joshbuker avatar Oct 01 '23 05:10 joshbuker

Could somebody just make a release and gem? plz :)

melroy89 avatar Feb 14 '24 15:02 melroy89

(Also commented under #700 ) although it appears "Fix deprecation warnings from Dart Sass" https://github.com/jekyll/minima/pull/700 is done, can someone please explain why - with the latest Jekyll and minima in my Gemfile - I’m still getting those deprecation warnings?

DaveEveritt avatar Jun 10 '24 15:06 DaveEveritt