jekyll-admin icon indicating copy to clipboard operation
jekyll-admin copied to clipboard
verified publisher icon jekyll

Add option to set admin specific scheme/host/port

Open CGillen opened this issue 3 years ago • 2 comments

Fixes #610 @ashmaroli mentioned they wanted tests on the fix. These might not be the best tests, so if you have any suggestions I'll gladly fix them up.

CGillen avatar May 16 '22 18:05 CGillen

@CGillen Thank you for proposing an enhancement.

From a quick glance, it looks like you're assuming site.config["jekyll_admin"] will always be defined. What if it isn't?

ashmaroli avatar May 16 '22 18:05 ashmaroli

#dig would be a better solution, wouldn't it? Doubtful site.config["jekyll_admin"] would be defined as anything besides a hash.

CGillen avatar May 16 '22 19:05 CGillen