jekyll-admin icon indicating copy to clipboard operation
jekyll-admin copied to clipboard

Published 20 hours ago • verified publisher icon jekyll

Update helpers.js

Open duongkhoangiam opened this issue 4 years ago • 2 comments

Completed create slug from string in Javascript

Fixes #613

duongkhoangiam avatar Nov 30 '20 11:11 duongkhoangiam

@duongkhoangiam Hey, thanks for the pr. Could you explain briefly what this pr solves?

Also, some tests are not passing here. We should fix them and add tests for new cases this pr fixes.

Edit: No worries. I just saw the issue and updated the description.

mertkahyaoglu avatar Nov 30 '20 11:11 mertkahyaoglu

When i using admin to created new post. the filename (path) leave blank to automatic generate is not completed for latin language, i am not sure this fix is solved or not because not sure the process generate file name from ruby or nodejs code. I hope we can add some nicely slugify to generate for latin language

Example when i type title is "Trump gây bàn tán vì ngồi bàn họp nhỏ bất thường" The filename generate is "2020-11-28-trump-gay-ban-tan-vi-ngi-ban-hp-nh-bt-thng.md"

This not correct because removed some characters. the correct is "2020-11-28-trump-gay-ban-tan-vi-ngoi-ban-hop-nho-bat-thuong.md"

duongkhoangiam avatar Dec 01 '20 07:12 duongkhoangiam