github-metadata icon indicating copy to clipboard operation
github-metadata copied to clipboard

Get path for first page of paginated pages

Open cmbuckley opened this issue 3 years ago • 3 comments
trafficstars

When a page is paginated, the edit link includes the pagination part of the URL. This grabs the path from the first page of the pagination collection.

I would appreciate some help with the tests as I'm not familiar enough with Ruby.

Closes #213

cmbuckley avatar Dec 22 '21 15:12 cmbuckley

Okay. The existing tests pass. Therefore, no regressions. Now you need to add the test that proves this change works (with your use-case) as claimed.

ashmaroli avatar Dec 22 '21 17:12 ashmaroli

Hmm, not what I was expecting. Although I note that the tests are running against Jekyll 4.2.1 and I was using 3.9.0 to match the version in github-pages gem.

cmbuckley avatar Dec 23 '21 01:12 cmbuckley

Seems like a useful bug fix.

parkr avatar Apr 04 '23 15:04 parkr