jekkos

I'm not completely convinced that we should merge this change as it stands here. In this case we can show the receipts / invoices in a different currency but I...

I thought about this a bit further and think that we should try to make this code as modular as possible. When you add a 3rd party integration, you will...

Same idea for the mailchimp integration: it's failry limited at this time and will only add customers to mailchimp that are created in ospos, if you have the integration setup...

I was checking whether it would not be better to integrate an existing library to take care of this example: https://eventsauce.io/

Intereseting read: https://martinfowler.com/eaaDev/EventSourcing.html

I think the eventsauce looks like it has some more functionality like support for testing, exception handling, event persistence, mesage generation from definition.. it feels like if we use something...

Ok I think the next step would be to map out what we have in the PR here against what this library offers, as you suggest. Basically this means redefining...

I see what you mean, you might want to have something minimal working first in that case so you can start using it already. I understand the urgency and it's...

This might be related to the payment reset fix that was done some time ago. This looks suspicious so someone might want to take a look here. First step is...

I've seen this pattern before so here and there, don't think it's new in CI4? Let's do the minimum first and then these kind of 'syntax' cleanups can be done...