raspberry-noaa-v2 icon indicating copy to clipboard operation
raspberry-noaa-v2 copied to clipboard

[Error] receive_noaa.sh : select pass_id after insert in database

Open jp112sdl opened this issue 3 years ago • 3 comments

Describe the bug Like in scripts/receive_meteor.sh the correct pass_id can be fetched after INSERT OR REPLACE INTO decoded_passes...

All push routines are using the wrong pass_id (from the previous pass): https://github.com/jekhokie/raspberry-noaa-v2/blob/3b27e438ab6018cd89544df4f49b1c5507e38251/scripts/receive_noaa.sh#L284-L358

jp112sdl avatar Jul 10 '21 08:07 jp112sdl

Hiya - I don't use slack with the RPI so not quite able to verify this, but on reading the code I think i see what you are highlighting.

I'd like to tag in @colinluthier and @Cadair .

Overall looking at the code something seems a little wrong to me.

I think that in https://github.com/jekhokie/raspberry-noaa-v2/blob/3b27e438ab6018cd89544df4f49b1c5507e38251/scripts/receive_meteor.sh that current lines 284 to 337 should be cut and pasted in between lines 275 and 276 so be moved into the same group that performs email and discord pushes.

I can't recall who added the slack updater - but for sure as @jp112sdl highlights - as it is is gets (pass_id - 1)...

dom-robinson avatar Jul 19 '21 09:07 dom-robinson

Is this issue still active?

MihajloPi avatar Oct 04 '23 08:10 MihajloPi

I think it is fixed. As I can see, all notifications (slack, twitter, ...) are now done after getting the actual pass_id.

jp112sdl avatar Oct 04 '23 11:10 jp112sdl