raspberry-noaa-v2 icon indicating copy to clipboard operation
raspberry-noaa-v2 copied to clipboard

SLACK_LINK vs. SLACK_LINK_URL

Open jp112sdl opened this issue 3 years ago • 1 comments

Hi!

While integrating the Pushover push service and looking around the other code I'm wondering where SLACK_LINK_URL is declared: https://github.com/jekhokie/raspberry-noaa-v2/blob/3b27e438ab6018cd89544df4f49b1c5507e38251/scripts/receive_noaa.sh#L296 https://github.com/jekhokie/raspberry-noaa-v2/blob/5e951ccc4ba0ed44513f2f8723ab3b6b82782746/scripts/receive_meteor.sh#L408

I can only find SLACK_LINK https://github.com/jekhokie/raspberry-noaa-v2/blob/3b27e438ab6018cd89544df4f49b1c5507e38251/ansible/roles/common/templates/noaa-v2.conf.j2#L85

Is it a typo or did I miss something?

jp112sdl avatar Jul 10 '21 06:07 jp112sdl

I think you are right - its a typo - should be SLACK_LINK i agree.

@colinluthier @Cadair - can you confirm too? I don't use SLACK so i can't really easily test...

dom-robinson avatar Jul 12 '21 17:07 dom-robinson