Johann Eicher

Results 13 comments of Johann Eicher

I feel like this could be low-hanging fruit for me as a first issue.

There's an additional issue here when building with 9.4: ```haskell • The ‘~’ operator is out of scope. Assuming it to stand for an equality constraint. • NB: ‘~’ used...

Yeah, thanks. Just updated the previous comment :)

The three failing tests don't seem to have anything to do with our contribution. The Docker Bootstrap test, at the very least, failed because Ubuntu failed to update. Perhaps someone...

> Hmm actually before deep diving into the review, is it currently only support submitting 1 task? It looks like current subclasses of Executor (ProcessExecutor and ThreadPoolExecutor) both has a...

> I made a first pass! Thanks for addressing the initial feedback. Thanks @rkooo567! We'll get to these comments ASAP.

Thanks for your prompt replies @rkooo567. I'm busy with a little bit of a refactor again to remove `ActorPool`s, as you suggested (and to clarify the object store issues). This...

> Sgtm! Let me know! I will follow up with the rest of comments when you get back to me :). Really excited for this contribution! I'm busy with this...

@rkooo567 @jjyao I've simplified this PR quite a bit by removing actor pools, and I've responded to the majority of your queries above. It seems to me that the major...

> Hi @nidabdella, > > Could you reply to the comments I posted above? We can also schedule a meeting to go through the design and make sure we are...