Jegor Kitškerkin
Jegor Kitškerkin
@amyeroberts Thanks for your comments. I have addressed everything. However, I still get the same problems with `make style` I did `git fetch upstream`, then `git rebase upstream/main`, `pip install...
hey @amyeroberts i've managed to fix the formatting-related problems and addressed your comments. However, I seem to be facing some problems with running tests. CI fails with ``` FAILED tests/models/vivit/test_modeling_vivit.py::VivitModelTest::test_model_outputs_equivalence...
@amyeroberts yep, everything works and passes locally
@amyeroberts I think it's ready to be merged. Thanks for your help!
Hey @NielsRogge, thanks! Sure
Hey @alaradirik, thanks for your reply and guidance! I will address what you suggested and add tests by the end of the week.
@alaradirik I've fixed the structuring via the suggested `transformers-cli add-new-model` and have run `make fixup`. All the relevant imports seem to work now (via `from transformers import ViViTModel, ViViTConfig, ViViTImageProcessor,...
@NielsRogge thanks for your reply! I was indeed looking at the CI and not picking up the issue because most of them display `No module named 'keras.saving.hdf5_format'` as the error,...
@NielsRogge apparently I have run what you provided incorrectly, sorry for that!
Okay np, fixed 👍