feishin icon indicating copy to clipboard operation
feishin copied to clipboard

Can't click on "Set rating"

Open ajpanton opened this issue 9 months ago • 3 comments

Expected Behavior

I expect the visibly existing "Set rating" to work, meaning clicking a rating does something, i.e. sets the rating of a song.

Current Behavior

In the context menu, hovering to "Set rating" to open the sub-menu with a list of available ratings (0-5 stars), clicking on the options does nothing. The menu stays open, I can single-, double- or triple-click all I want, but absolutely nothing happens. Only if I click slightly outside of the actual row of stars (on either side) will the menu close, but it doesn't set or change the rating of the song I originally right-clicked.

Other players, like Symfonium on Android, or Supersonic on Windows, work fine.

Steps to Reproduce

I'm using Feishin as a Subsonic client, streaming from lms.

Open a list of songs, right click one of them, go to "Set rating" and try to choose one of the options.

Possible Solution

No response

Context

Trying to set or change the rating of a song.

Application version

0.12.2

Operating System and version

Windows 10 desktop

Server and Version

lms 3.64.0

Node Version (if developing locally)

No response

ajpanton avatar Mar 07 '25 04:03 ajpanton

I get the same thing trying to add to favorites using Navidrome as a server.

quamok avatar Mar 11 '25 12:03 quamok

I confirm, I see the same thing, the context menu does not work.

If I have single song selected, or multiple.

However, if I add "Rating" the the table view or open an album, I can set the rating by clicking the stars in the column. I confirmed that this actually updates the ratings on the server.

FYI: I am using Navidrome 0.55.1, Feishin 0.12.3, on Fedora 241

Interestingly, unlike what @quamok mentioned, I can use the context menu to "add to favorites" and remove

copart avatar Mar 21 '25 16:03 copart

Sorry, add to favorites is working, it was just taking a lot of time for a lot of tracks.

quamok avatar Mar 22 '25 12:03 quamok

It was an issue with the star icons overriding the pointer click event on the context menu button. If you clicked anywhere in the button outside of the star icon, it would work.

Image

jeffvli avatar May 07 '25 01:05 jeffvli