feishin icon indicating copy to clipboard operation
feishin copied to clipboard

Taskbar menu translation missing

Open tianmiao8152 opened this issue 1 year ago • 8 comments

Expected Behavior

Current Behavior

Steps to Reproduce

Possible Solution (Not obligatory)

Context

Your Environment

  • Application version (e.g. v0.1.0) :0.5.3
  • Operating System and version (e.g. Windows 10) :Windows 10
  • Server and version (e.g. Navidrome v0.48.0) :Navidrome 0.51.0 (fd61b29a)
  • Node version (if developing locally) :

tianmiao8152 avatar Feb 14 '24 09:02 tianmiao8152

What operating system are you on? What language did you set Feishin to use?

iiPythonx avatar Feb 14 '24 17:02 iiPythonx

What operating system are you on? What language did you set Feishin to use?

Windows 10 Pro 22H2,language is chinese I think it's a problem of lost translation key.

tianmiao8152 avatar Feb 14 '24 17:02 tianmiao8152

So, what do you mean by the taskbar menu?

Closest thing I can think of would be the hover window: image

(In which everything is in English, ~~I'm not sure Feishin controls the text that shows up in that window~~.)

iiPythonx avatar Feb 14 '24 17:02 iiPythonx

OK, I probably should have put up the pictures in advance. image

tianmiao8152 avatar Feb 14 '24 17:02 tianmiao8152

Oh, I see what you mean.

~~I'm not sure about the Stop/Open Main Window/Quit keys~~ All of those are controlled by Feishin (my bad). ie. see https://github.com/jeffvli/feishin/blob/development/src/main/main.ts#L157-L197

I guess they just need to have translation keys added to them.

iiPythonx avatar Feb 14 '24 17:02 iiPythonx

OK, I think most of the translation keys already exist and can be reused. This is not a big problem.

tianmiao8152 avatar Feb 14 '24 17:02 tianmiao8152

Oh, I see what you mean.

~I'm not sure about the Stop/Open Main Window/Quit keys~ All of those are controlled by Feishin (my bad). ie. see https://github.com/jeffvli/feishin/blob/development/src/main/main.ts#L157-L197

I guess they just need to have translation keys added to them.

还没有更新吗?

tianmiao8152 avatar Mar 09 '24 13:03 tianmiao8152

还没有更新吗?

Unfortunately not, I'm unable to add this feature myself because it would take quite a bit of work to be able to pull your language setting correctly in the main app file.

iiPythonx avatar Mar 09 '24 22:03 iiPythonx