feishin icon indicating copy to clipboard operation
feishin copied to clipboard

[Essential] Subsonic API Support

Open kobayashi90 opened this issue 1 year ago • 8 comments

Why Feishin does need the Subsonic API Now? As previously mentioned over here there is an essential need to enable the Subsonic API. Navidrome relies upon it heavly all the time, there are basically no clients that dont rely on navidrome's own api due to compability reasons i assume.

Why there is no reason that we need to wait for Subsonic's API changes? After researching the Link that got mentioned on the Githubs Readme turnts out there is no eta or any development on new subsonic api changes so there is basically no need to wait for future subsonic api changes. Even if someone rebuilds it, it takes up months if not years due to how old subsonic is in some regards. So i hope this gets fixed as fast as possible.

kobayashi90 avatar Oct 14 '23 06:10 kobayashi90

image tried using gonic with feishin it errors out with 'please prodive a 'u' parameter when clicking tracks login doesnt seem to work either

Sakooooo avatar Oct 15 '23 17:10 Sakooooo

After researching the Link that got mentioned on the Githubs Readme turnts out there is no eta or any development on new subsonic api changes so there is basically no need to wait for future subsonic api changes.

Just throwing in my 2 cents: It's worth exploring for Feishin to look into the OpenSubsonic API. I believe the OpenSubsonic API is the end result of the thread that was linked in the README

ProfMoo avatar Oct 18 '23 17:10 ProfMoo

Just throwing in my 2 cents: It's worth exploring for Feishin to look into the OpenSubsonic API. I believe the OpenSubsonic API is the end result of the thread that was linked in the README

Edit: I apologize if this sounds rude, ive had an tantrum about it,.. take your time. Edit 2: Got notified that they work on it soon, so lets wait until its done.

kobayashi90 avatar Oct 19 '23 05:10 kobayashi90

Is there any chance to have gonic/opensubsonic as client too? It will be great. At the moment which one is the best client? Jellyfin or Navidrone?

Gt1ult avatar Nov 04 '23 22:11 Gt1ult

FYI, its on its way --> #419

luopa avatar Jan 11 '24 09:01 luopa

FYI, its on its way --> #419

It failed tho, not sure how optimistic we should be.. @jeffvli might know..

kobayashi90 avatar Jan 24 '24 14:01 kobayashi90

It failed tho, not sure how optimistic we should be.. jeffvli might know..

Running off of #419, your server "squidify" (from #289) seems to load perfectly fine:

image

Additionally, if by "failed" you meant the "Some checks were not successful" notice, then it's worth noting that's just because of some basic missing configuration when building for MacOS:

image

It should just be a matter of waiting for it to be finalized and merged.

iiPythonx avatar Jan 31 '24 01:01 iiPythonx

It should just be a matter of waiting for it to be finalized and merged.

Indeed great news, i hope it happens soon because till now many people used SoniXD including myself.. I did also use Feishin over an Tailscale connection but its clearly not an option for other listeners.

kobayashi90 avatar Feb 02 '24 03:02 kobayashi90

Can we get a little estimate when it will be implemented ? I'm still stuck with Sonixd because of the lack of support of Subsonic…

Edit : or release https://github.com/jeffvli/feishin/pull/419 : yes you will say "it's old and you will lack features", but am I really lacking something when Sonixd isn't maintained at all ?

garfieldairlines avatar Sep 14 '24 17:09 garfieldairlines

Can we get a little estimate when it will be implemented ?

jeffvli is planning/working on yet another rewrite which according to him will have support for subsonic.
It's not public yet and I don't have any more information about it then that.

Also, if you just want a build of #419, I have a build available here (Linux/Windows only).

iiPythonx avatar Sep 14 '24 18:09 iiPythonx

Also, if you just want a build of #419, I have a build available here.

Oooooooooooooh thank you so much

garfieldairlines avatar Sep 14 '24 18:09 garfieldairlines

The likelihood of it hitting Feishin regular as-is is basically none. Unless someone (who is not me) spends the time to refine the linked PR and resolve all merge conflicts, it will likely not happen.

kgarner7 avatar Sep 14 '24 21:09 kgarner7

:face_exhaling: in light of Navidrome filtering making things worse, I'm taking a stab at this. Note that it will be a different branch (I'm not dealing with all those merge conflicts). My first goal will be to port over the changes that will support subsonic (without actually supporting subsonic) to make sure the quality of Navidrome/Jellyfin native isn't impacted. If that's the case, then adding Subsonic back is easy.

kgarner7 avatar Sep 19 '24 14:09 kgarner7