Feishin shows genres of the video content instead of music on the genres page

[yacoob]

Expected Behavior

When I click on Genres in the sidebar, I'd expect to see list of genres of the music available on the Jellyfin server I'm using.

Current Behavior

Instead of the above, I can see a list of genres for the video content present on the same server. There are also "empty" genres based on the music Feishin has played in this session.

Steps to Reproduce

1. Launch Feishin

2. Set it up to work with a Jellyfin server

3. Click on Genres in the sidebar

Your Environment

• Application version (e.g. v0.1.0) : 0.3.0
• Operating System and version (e.g. Windows 10) : Win11 Pro 22621.2283
• Server and version (e.g. Navidrome v0.48.0) : Jellyfin 10.8.10

[yacoob]

Still present in 0.4, FWIW.

[BlackDragon-B]

Just checked the problem and the query used for listing the genres is missing the includeItemTypes parameter, thus it's showing all genres instead of only the ones relevant to music. While this would solve the issue it does strike me as odd that there are quite an amount of genres missing in the list. Since for me it's only returning 8 genres instead of the 31 present on my mediaserver.

https://github.com/jeffvli/feishin/blob/3bbe696f4c9520492b3258d12cc082dbf451162d/src/renderer/api/jellyfin/jellyfin-controller.ts#L155C12-L155C12

[BlackDragon-B]

I checked the official implementation and it seems that the ParentId parameter is crucial for returning all genres. I'll try implementing a fix for this today.

[jeffvli]

The parentId is already used on the genres list when selecting a filter via the folder icon in the header.

I think the issue is that there's no way to fetch all genres from only music libraries like @BlackDragon-B noted, the includeItemTypes parameter doesn't properly return genres.

To fix this we would need to update the getGenresList endpoint to have a condition where if parentId isn't specified, we need to:

1. Fetch all media libraries in the Jellyfin server and filter by music libraries only
2. Fetch the genres from each individual library using the parentId of each
3. Deduplicate and return all the unique genres

[pbasov]

For me the music genres don't show up at all on the Genres page. I only have a music library on my Jellyfin.

They are picked up, however, in other views like the Album page.

[harrythezomby]

I'm getting this on 0.7.1 as well. Has anyone found a fix? It looks like it's picking up the genres + thumbnails from my Anime section and not Music.