Create a flatpak version

[AuroraViola]

Would be really usefull if you can create a flatpak version that will be installable from flathub. Almost all of my GUI application are flatpak and I don't want Feishin to be the only appimage application.

[jeffvli]

I'll attempt this once Feishin comes out of alpha.

Still a missing a few key features!

[WhyKickAmooCow]

I have a flatpak manifest for feishin here if you were interested.

It is currently just broken because of mpris-service in the main package.json dependencies (webpack doesn't like native deps), and that node-abi needs to be updated. That is unless I am missing something for building Feishin that would fix these being an issue.

[herzenschein]

Hi, I've been testing this experimental flatpak for a while. There are four issues with it, where only one is a dealbreaker.

1. As a best practice you should use --socket=fallback-x11 instead of --socket=x11.

2. I get the warning: [18:0318/225321.668184:ERROR:bus.cc(407)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory which is only solved if the application is granted system bus access. I wonder why the app needs system bus instead of just session bus, though. :thinking:

3. For Feishin to store its password on KDE Plasma, it needs --talk-name=org.kde.kwalletd5 and --talk-name=org.kde.kwalletd6. Otherwise the user gets a message saying there was an error saving the password.

4. The only dealbreaker I've seen is that when the Navidrome server goes down and back up, Feishin is started, and then attempts to connect, its window loops between a loading screen and a "No issues found: Go Back" screen, with continuous errors in the terminal saying 22:45:00.818 › [AUDIO PLAYER] Setting properties: {"speed":1}.

The three first are trivial to fix, the fourth one I don't know how to deal with. I don't remember having this issue with the non-flatpak version.

I'd love if Feishin was added to Flathub, it may be alpha but it's already the best client for Navidrome out there.

[WhyKickAmooCow]

The socket x11 permission was in the case of wayland and nvidia, it will crash if not using xwayland for some reason. I can try to see if it will work with the fallback x11, but there is a reason.

I'm not sure why it would need system dbus either, but since it works fine without I haven't given it access (better to give as few permissions as possible).

Strangely enough, I use KDE but have never encountered the message about an error saving the password. I wasn't even aware Feishin had wallet support. I can add those permissions.

I haven't encountered this either, maybe this is an issue with MPV in the flatpak, do you know if the same issue occurs with the web player?

[herzenschein]

I haven't encountered this either, maybe this is an issue with MPV in the flatpak, do you know if the same issue occurs with the web player?

Last I tried, it was using the web backend (it's the default). Switching it to MPV didn't really address the issue either.

I recently got my hands into a Raspberry Pi and moved my music server to it, I'll be testing this again in the next few days.

[nexy7574]

I have a flatpak manifest for feishin here if you were interested.

Just installed this, works a charm (KDE Fedora 40, NVIDIA proprietary driver, xwayland)

[Farnjang]

I have a flatpak manifest for feishin here if you were interested.

@WhyKickAmooCow is it possible to enable bs2b in your flatpak? https://github.com/jeffvli/feishin/issues/265

Tried --af-add=lavfi=[bs2b=profile=default] and --af=lavfi=[bs2b=profile=jmeier] but I get a hardware error

Works great tho. Should be official!