jekyll-spaceship icon indicating copy to clipboard operation
jekyll-spaceship copied to clipboard

Published 20 hours ago • verified publisher icon jeffreytse

support gemoji 4.0.0

Open casperdcl opened this issue 2 years ago • 3 comments

vis. https://github.com/jekyll/jemoji/issues/122

See https://github.com/github/gemoji/releases/tag/v4.0.0.pre0 for breaking changes.

casperdcl avatar Nov 25 '22 16:11 casperdcl

For anyone planning on submitting a pull request: you need not drop support for Gemoji v3 for backwards compatibility. Relaxing the constraint to allow Gemoji v4 should suffice.

ashmaroli avatar Nov 25 '22 17:11 ashmaroli

yes, >=3, <5 is probably safest :)

casperdcl avatar Nov 25 '22 17:11 casperdcl

Any progress about this issue? @jeffreytse

Freed-Wu avatar Apr 13 '23 12:04 Freed-Wu