Jeff Posnick
Jeff Posnick
Based on my experience with a standalone repro ([linked to](https://cdn.rawgit.com/jeffposnick/5e45336189dbb476ec74/raw/4e23909e8b784ff7a821a6bd820f4ad5b1516881/index.html) from the [Chrome bug report](https://code.google.com/p/chromium/issues/detail?id=546076)), that wouldn't help. You can rewrite the request to be `{mode: 'no-cors'}`, but since the...
All good points. For now, it's `¯\_(ツ)_/¯` and we'll have to see what the performance and reliability implications are of different approaches when the underlying `waitUntil()` is there.
See also: https://github.com/slightlyoff/ServiceWorker/issues/790
I think it's cleanest to implement that bit of logic independent of `sw-toolbox`: ``` js const OFFLINE_URL = '/path/to/offline.html'; toolbox.precache(OFFLINE_URL); // Make sure this fetch event handler appears before any...
I'm not in favor of something resource-type-specific, like `offlineFallbackpage`, or `offlineFallbackimage`. You'd end up with a large number of similarly-named options that were tied to the types of resources. I...
This is generally a good idea, and is necessary for some specific use cases. (Though I'm not sold on handlers taking responsibility for calling `event.respondWith()`.) Exposing the `FetchEvent` is part...
My initial reaction is that it developers who want that guarantee should explicitly add the [`crossOrigin` attribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#attr-crossorigin) to the relevant resources in the DOM. That has the benefit of preventing...
Thanks for reporting this. Moving your `workbox.googleAnalytics.initialize()` call so that it's earlier than any calls to `registerRoute()` should resolve the issue, but I understand that it's unexpected. I'll keep this...
We should probably do for `workbox-google-analytics` in v6 what we're doing for `workbox-precaching`, and have it use the default `Router` instance instead of creating its own. CC: @philipwalton
Actually, I forgot that `workbox-precaching` in v6 creates it own `Router` instead of using the default `Router`, so forget what I said about it being similar.