Jeff McAffer

Results 60 comments of Jeff McAffer

@mbroadst Fantastic news. Thanks Matt. If you have something that you want some mileage on, let me and @willbar know. We have a test setup that we can use to...

FYI, another very similar case we just saw (throwing in the event handler) had this stack trace ``` AmqpMalformedPayloadError: malformed payload: Unknown code: 0x5c at Codec._asMostSpecific (/home/ospo/prod/ospo-ghcrawler/node_modules/amqp10/lib/codec.js:113:11) at Codec.decode (/home/ospo/prod/ospo-ghcrawler/node_modules/amqp10/lib/codec.js:138:22)...

Yeah, we were wondering about the best course of action as well. Shutting down the connection and restarting might be the best thing. Crashing the service is less than optimal....

FWIW, I just got a mess of these. No idea what it means... The system was pushing a fair bit (~100/s) to a queue. ``` received when no incoming window...

I caught a hang while debug was on. See the attached log. Note that this is running the code in my fork that has an extra try/catch around the _sendMessage...

Here is the full log for that run. Interestingly, looking back at the full log, there is more than I first posted. Seems that 10 min after the hang, it...

@mbroadst Thanks for the quick reply! Feel free to check out [the code of our queue receiver](https://github.com/Microsoft/ospo-ghcrawler/blob/develop/lib/amqp10Queue.js). We create 5 of those in [ospoCrawler.js](https://github.com/Microsoft/ospo-ghcrawler/blob/develop/lib/ospoCrawler.js#L389). Could just as well switch to...

D'oh. Public now.

I've not tried this directly but this problem appears (at least) when receiving a message that is larger than the configured size for the receiver_link. Some of our messages get...

+1 to maintaining the original format of the licenses. Currently, for example, these two license texts differ by newlines. https://github.com/spdx/tools/blob/master/resources/stdlicenses/MIT.jsonld https://github.com/OpenSourceOrg/licenses/blob/master/texts/plain/MIT While it is not a huge deal for consumers...