Contrastive-Predictive-Coding-PyTorch icon indicating copy to clipboard operation
Contrastive-Predictive-Coding-PyTorch copied to clipboard

Hey should 'correct' only be if the final prediction was correct? Same for accuracy?

Open colinator opened this issue 5 years ago • 1 comments

https://github.com/jefflai108/Contrastive-Predictive-Coding-PyTorch/blob/a9dab4e759aaa68dce1b1ada46a8035076ba3296/src/model/model.py#L100

Meaning, should that correct variable be += ?

colinator avatar Sep 19 '20 03:09 colinator

I noticed that too.

I think you're right, and after the loop over the timesteps, the sum should be divided by batch_size*num_of_timesteps.

NeteeraAF avatar Jan 21 '21 13:01 NeteeraAF