Contrastive-Predictive-Coding-PyTorch icon indicating copy to clipboard operation
Contrastive-Predictive-Coding-PyTorch copied to clipboard

NCE accuracy calculation

Open JaejinCho opened this issue 5 years ago • 1 comments

Hello @jefflai108,

I think the accuracy also should have its denominator as batch*self.timestep at https://github.com/jefflai108/Contrastive-Predictive-Coding-PyTorch/blob/a9dab4e759aaa68dce1b1ada46a8035076ba3296/src/model/model.py#L320

Possibly for other models too although I did not check them.

JaejinCho avatar Jun 28 '20 01:06 JaejinCho

Yes, and it should be correct += I believe, just above there...

colinator avatar Sep 19 '20 03:09 colinator