httpclientgoodies.net
httpclientgoodies.net copied to clipboard
jeffijoe
Update the library to use .Net standard 1/2.x
It would be really nce if the library were updated to be compatible with .net standard 1 or 2.0, which ever makes more sense.
OK, I will! Should we also update things so that the NuGet packages are inthe project file as per vs2017's format?
I havent really done .NET for a while so I’m not sure what that does, but it sounds like it’s something we’d want? 😅
It removes the packages.config file ensuring that packages are restored to a Nuget package folder on the system rather than a folder within the folder containing the solution file. The usual package restore location is: C:\Users\SeanFarrow.nuget\packages On this machine.
It will also mean the project can be opened with visual studio 2017 15.7 or later, given that vs 2019 has been released and the fact there is a free community edition, I don’t see this is an issue. I will also take the liberty of updating all NuGet packages.
From: Jeff Hansen [email protected] Sent: 17 April 2019 20:45 To: jeffijoe/httpclientgoodies.net [email protected] Cc: Sean Farrow [email protected]; Author [email protected] Subject: Re: [jeffijoe/httpclientgoodies.net] Update the library to use .Net standard 1/2.x (#2)
I havent really done .NET for a while so I’m not sure what that does, but it sounds like it’s something we’d want? 😅
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jeffijoe/httpclientgoodies.net/issues/2#issuecomment-484233872, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABY1fqZAaEAk-00zxQLocsk9UhkUTMdxks5vh3mhgaJpZM4c1wNL.
Sounds great! Will be fun to see if I even remember how to publish packages, hopefully its gotten easier.
If you have problems, I’m happy to help!
From: Jeff Hansen [email protected] Sent: 17 April 2019 21:04 To: jeffijoe/httpclientgoodies.net [email protected] Cc: Sean Farrow [email protected]; Author [email protected] Subject: Re: [jeffijoe/httpclientgoodies.net] Update the library to use .Net standard 1/2.x (#2)
Sounds great! Will be fun to see if I even remember how to publish packages, hopefully its gotten easier.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jeffijoe/httpclientgoodies.net/issues/2#issuecomment-484240287, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABY1fo2wE7RKSSgBbY51D2cfWodDmWhHks5vh348gaJpZM4c1wNL.
I’ll try to get it done this weekend, unless I can do it from my Mac now? I tried publishing from a Mac before and it didnt work 🤔
Strange, that usually works.
I’ll do the update tomorrow.
Cheers Sean.
From: Jeff Hansen [email protected] Sent: 17 April 2019 21:09 To: jeffijoe/httpclientgoodies.net [email protected] Cc: Sean Farrow [email protected]; Author [email protected] Subject: Re: [jeffijoe/httpclientgoodies.net] Update the library to use .Net standard 1/2.x (#2)
I’ll try to get it done this weekend, unless I can do it from my Mac now? I tried publishing from a Mac before and it didnt work 🤔
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jeffijoe/httpclientgoodies.net/issues/2#issuecomment-484241951, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABY1fl5pZikXmkmlnLlDlOiujYxBtwYfks5vh39hgaJpZM4c1wNL.
Ok, I’m updating things to .Net standard 2.0/.Net core 2.1 and am getting a whole heap of errors from HttpMock. Firstly, HttpMock does use proper dictionary handling and doesn’t take account of concurrency. Secondly, the HttpClient has become more intolerant of incorrectly formatted responses. I’m tempted to switch the library out for something I know works, it works on the same principles of building a request/response, let me know if you are OK with this?
From: Jeff Hansen [email protected] Sent: 17 April 2019 21:09 To: jeffijoe/httpclientgoodies.net [email protected] Cc: Sean Farrow [email protected]; Author [email protected] Subject: Re: [jeffijoe/httpclientgoodies.net] Update the library to use .Net standard 1/2.x (#2)
I’ll try to get it done this weekend, unless I can do it from my Mac now? I tried publishing from a Mac before and it didnt work 🤔
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jeffijoe/httpclientgoodies.net/issues/2#issuecomment-484241951, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABY1fl5pZikXmkmlnLlDlOiujYxBtwYfks5vh39hgaJpZM4c1wNL.
Are you suggesting switching the HttpClient, or switching to a different mock for tests?
I don't think switching the HttpClient is a good idea because consumers depend on the ability to pass in their own, or to just create the HttpRequestMessage and send that with their own client.
Unless there's something I am misunderstanding? 😄
I’m suggesting switching the mocking for tests. I’d definitely not suggest switching from HttpClient as it’s the standard now.
From: Jeff Hansen [email protected] Sent: 18 April 2019 06:56 To: jeffijoe/httpclientgoodies.net [email protected] Cc: Sean Farrow [email protected]; Author [email protected] Subject: Re: [jeffijoe/httpclientgoodies.net] Update the library to use .Net standard 1/2.x (#2)
Are you suggesting switching the HttpClient, or switching to a different mock for tests?
I don't think switching the HttpClient is a good idea because consumers depend on the ability to pass in their own, or to just create the HttpRequestMessage and send that with their own client.
Unless there's something I am misunderstanding? 😄
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jeffijoe/httpclientgoodies.net/issues/2#issuecomment-484366374, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AALDK7T3RGUYC52SYKTTS6LPRAEQPANCNFSM4HGXANFQ.
Just something else I’ve noticed, in your tests, you don’t set the accept header, is this deliberate?
From: Jeff Hansen [email protected] Sent: 18 April 2019 07:05 To: jeffijoe/httpclientgoodies.net [email protected] Cc: Sean Farrow [email protected]; Author [email protected] Subject: Re: [jeffijoe/httpclientgoodies.net] Update the library to use .Net standard 1/2.x (#2)
Ah, excellent, yes by all means! 😄
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jeffijoe/httpclientgoodies.net/issues/2#issuecomment-484368196, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AALDK7QBAW6FMGCLUR762ODPRAFSTANCNFSM4HGXANFQ.
Not deliberate, never had to do it myself. If you need to add it, feel free. 😄
OK, Leavve this with me, things might take a few days, as I’ve got interviews going on for new jobs and I need to reformat a machine after backing up a whole chunk of source code so that I can use .Net Core 3.
From: Jeff Hansen [email protected] Sent: 18 April 2019 18:51 To: jeffijoe/httpclientgoodies.net [email protected] Cc: Sean Farrow [email protected]; Author [email protected] Subject: Re: [jeffijoe/httpclientgoodies.net] Update the library to use .Net standard 1/2.x (#2)
Not deliberate, never had to do it myself. If you need to add it, feel free. 😄
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jeffijoe/httpclientgoodies.net/issues/2#issuecomment-484612365, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AALDK7TA4P4ERRBZSBYZOGTPRCYIBANCNFSM4HGXANFQ.